diff mbox series

[RFC,V2,05/12] dt-bindings: i2c: tegra-i2c: reference to config

Message ID 20240701151231.29425-6-kyarlagadda@nvidia.com
State New
Headers show
Series Introduce Tegra register config settings | expand

Commit Message

Krishna Yarlagadda July 1, 2024, 3:12 p.m. UTC
I2C interface timing registers are configured using config setting
framework. Add reference to I2C config settings.

Signed-off-by: Krishna Yarlagadda <kyarlagadda@nvidia.com>
---
 .../devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml          | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring (Arm) July 1, 2024, 4:58 p.m. UTC | #1
On Mon, 01 Jul 2024 20:42:23 +0530, Krishna Yarlagadda wrote:
> I2C interface timing registers are configured using config setting
> framework. Add reference to I2C config settings.
> 
> Signed-off-by: Krishna Yarlagadda <kyarlagadda@nvidia.com>
> ---
>  .../devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml          | 5 +++++
>  1 file changed, 5 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml: config-settings: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240701151231.29425-6-kyarlagadda@nvidia.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
index 424a4fc218b6..2f6f12149876 100644
--- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
@@ -119,6 +119,11 @@  properties:
       - const: rx
       - const: tx
 
+  config-settings:
+    items:
+      - description: phandle to the i2c configuration settings
+      - $ref: /schemas/types.yaml#/definitions/phandle
+
 allOf:
   - $ref: /schemas/i2c/i2c-controller.yaml
   - if: