From patchwork Wed Jan 31 14:16:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarkko Nikula X-Patchwork-Id: 768668 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84A0B7F48F for ; Wed, 31 Jan 2024 14:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706710645; cv=none; b=ta5Bpa/V3lXBgKtXqPbLO34jqaElEh3I6CtbRrrbKWUZCKCPtgtTGphnp4gJrd5eKBdooBPnD482GM6arlpwLXrIAxscHgFlgYmtgyxzo4PIU+9Zco2E7aQXvdkQRGMHvK91T1k9I1EVsgK4ZGPmXSEf5mFcH488J10XoPAFQY4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706710645; c=relaxed/simple; bh=1aKDNz7zbM0I5hek9PLCcgd8MCkmbiz3Mn3zShsxDso=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ISYMaYROIn6LpahTG7awnx36acIaQIjhR5zam85r4mTPdBbYV9ur2GhjG7ExyXNuU6/IYp878Ox5m6Xn1MaQEjkC6PRaVwZOdGS/wrsuVGM3O3PPKr+FNSAt5M7/BKbdx7XU/V4VZkAP2XRY4Kounhoa0POb8DdNPhEfMQQ5v/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=V60nfjsf; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="V60nfjsf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706710644; x=1738246644; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1aKDNz7zbM0I5hek9PLCcgd8MCkmbiz3Mn3zShsxDso=; b=V60nfjsfCfE1HgEBvAP6BPpFEWA2PA/ESlGgaqxi9kVi45Ljh8OW0W8G XvyHwkvMhRGCUPIalc9reUfCSn+PgXWrS435HccgL3W3TK0BUDI8Qkry6 x8gPpKL/VCnHRhvsTQo05rCpX4VKjA+PAToUP93MuM5inaliazSO1VyYm g19K11O8nL1mJ6QEkzK8UbgM3xtRLD8V6wqxmywiH7oUbQEzZincevN0a SCrqGyGrSODVq/kGhs7wQM/MqJUWl6TX9bZML5Bwjw4059Uwi9Ds0XChL +zfK/qrWthFyaA2c7osgfIB0j31I0NhA0zpEKjLxgWNs/hTNDsbbR2+Vw A==; X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="3460493" X-IronPort-AV: E=Sophos;i="6.05,231,1701158400"; d="scan'208";a="3460493" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2024 06:17:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="788591920" X-IronPort-AV: E=Sophos;i="6.05,231,1701158400"; d="scan'208";a="788591920" Received: from unknown (HELO mylly.fi.intel.com.) ([10.237.72.79]) by orsmga002.jf.intel.com with ESMTP; 31 Jan 2024 06:17:19 -0800 From: Jarkko Nikula To: linux-i2c@vger.kernel.org Cc: Andi Shyti , Andy Shevchenko , Mika Westerberg , Jan Dabros , Jiawen Wu , Sanket Goswami , Basavaraj Natikar , Ruhl, Michael J , Jarkko Nikula Subject: [PATCH 5/6] i2c: designware: Fix RX FIFO depth define on Wangxun 10Gb NIC Date: Wed, 31 Jan 2024 16:16:51 +0200 Message-ID: <20240131141653.2689260-6-jarkko.nikula@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240131141653.2689260-1-jarkko.nikula@linux.intel.com> References: <20240131141653.2689260-1-jarkko.nikula@linux.intel.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I believe RX FIFO depth define 0 is incorrect on Wangxun 10Gb NIC. It must be at least 1 since code is able to read received data from the DW_IC_DATA_CMD register. For now this define is irrelevant since the txgbe_i2c_dw_xfer_quirk() doesn't use the rx_fifo_depth member variable of struct dw_i2c_dev but is needed when converting code into generic polling mode implementation. Signed-off-by: Jarkko Nikula --- drivers/i2c/busses/i2c-designware-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index 4d277ebcca92..bf8f140dc113 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -319,7 +319,7 @@ struct dw_i2c_dev { #define AMD_UCSI_INTR_EN 0xd #define TXGBE_TX_FIFO_DEPTH 4 -#define TXGBE_RX_FIFO_DEPTH 0 +#define TXGBE_RX_FIFO_DEPTH 1 struct i2c_dw_semaphore_callbacks { int (*probe)(struct dw_i2c_dev *dev);