From patchwork Mon Nov 7 13:42:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarkko Nikula X-Patchwork-Id: 622487 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FFB5C433FE for ; Mon, 7 Nov 2022 13:43:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231720AbiKGNnW (ORCPT ); Mon, 7 Nov 2022 08:43:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231742AbiKGNnV (ORCPT ); Mon, 7 Nov 2022 08:43:21 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DD911CB3D for ; Mon, 7 Nov 2022 05:43:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667828600; x=1699364600; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ShV0WAjYrwkSHJUUc2Z7FLDOm7nPdvgybotW6nJt3UU=; b=nNna0mM/jpTFY6B78MRhcImy+Ewc/tU2dTuf3oo1eb2kyb0li5af8C8O bnhUcYXRpKpu5nmEVC2adne+CRj2gqpcj87l6FVJSDP5IoCzGDBFOV0V2 OtYBNbG/qbdXIxqiTDvQJ86L3yjkBSPFlWr8H61sfoCJZpjgwgfIjcPoH 4VQXBMZqTmV7SlbfLNBKUh/98Ho5jHoJQq1mbnVW2eOxI0/r61uYZADdm jjcejIA/mTWJD4CG4sv8xLOaDSl+fAe6dUmUTbU4eOsfLiVtkOLW9c1Dm 8qrko4PQR9Vespt2TGg4i5bqfhAV823n8QTNkV0ynX2s4WFlh89nPch3t A==; X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="372531139" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="372531139" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 05:43:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="586971919" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="586971919" Received: from mylly.fi.intel.com (HELO mylly.fi.intel.com.) ([10.237.72.55]) by orsmga003.jf.intel.com with ESMTP; 07 Nov 2022 05:43:17 -0800 From: Jarkko Nikula To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andy Shevchenko , Mika Westerberg , Jan Dabros , Michael Wu , Tian Ye , Jarkko Nikula Subject: [PATCH v3 08/12] i2c: designware: Move debug print in i2c_dw_isr() Date: Mon, 7 Nov 2022 15:42:44 +0200 Message-Id: <20221107134248.864890-9-jarkko.nikula@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221107134248.864890-1-jarkko.nikula@linux.intel.com> References: <20221107134248.864890-1-jarkko.nikula@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org It is kind of needless to print interrupt status when code immediately after that finds interrupt was not originating from this device. Therefore move it after spurious interrupt detection. Signed-off-by: Jarkko Nikula Reviewed-by: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c index d6fcf955dfc0..9c2c9d002dc3 100644 --- a/drivers/i2c/busses/i2c-designware-master.c +++ b/drivers/i2c/busses/i2c-designware-master.c @@ -775,11 +775,11 @@ static irqreturn_t i2c_dw_isr(int this_irq, void *dev_id) regmap_read(dev->map, DW_IC_ENABLE, &enabled); regmap_read(dev->map, DW_IC_RAW_INTR_STAT, &stat); - dev_dbg(dev->dev, "enabled=%#x stat=%#x\n", enabled, stat); if (!enabled || !(stat & ~DW_IC_INTR_ACTIVITY)) return IRQ_NONE; if (pm_runtime_suspended(dev->dev) || stat == GENMASK(31, 0)) return IRQ_NONE; + dev_dbg(dev->dev, "enabled=%#x stat=%#x\n", enabled, stat); i2c_dw_irq_handler_master(dev);