From patchwork Wed Oct 26 12:39:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarkko Nikula X-Patchwork-Id: 619925 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF5C3C38A2D for ; Wed, 26 Oct 2022 12:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233742AbiJZMkn (ORCPT ); Wed, 26 Oct 2022 08:40:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233927AbiJZMkL (ORCPT ); Wed, 26 Oct 2022 08:40:11 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AD2E57577 for ; Wed, 26 Oct 2022 05:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666787994; x=1698323994; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=07aBnTZg9U7h7TZJbY2qYIBKm5DBn+L07PLUf8Zv5j4=; b=A7praQIkc+dCYVmX2lbelaA/qDLdhss/9juIlrRMWVleLfg6YvUqtNju rVC+x8XgM/qsLeOWoqu82kEUzjDJUM7kXhg7J2INFZ/hxTMcTD9Ky7tWs UQ74mFrhTKF93bU0yRczSFeuqLhEikgr4FaiQ2kIKPrOBeGO6bbuXGlfj ob10MKcqXrPJMv9vRLRg8ScauMQrgZ3CJ7V1HaVfU84R8vJ+9srxY+AiB UVzNLnhBk9P00RPJP39oSSXf4BosxbqgVvH2ZUx6XrgosZXlqqcgxFucN jP+BZyFPzIGLFfd1eb/EHODi+vM/R+hj/BtadZZLdTx3sxHfmhRidZKz7 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="309625076" X-IronPort-AV: E=Sophos;i="5.95,214,1661842800"; d="scan'208";a="309625076" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2022 05:39:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="700908711" X-IronPort-AV: E=Sophos;i="5.95,214,1661842800"; d="scan'208";a="700908711" Received: from mylly.fi.intel.com (HELO mylly.fi.intel.com.) ([10.237.72.55]) by fmsmga004.fm.intel.com with ESMTP; 26 Oct 2022 05:39:50 -0700 From: Jarkko Nikula To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andy Shevchenko , Mika Westerberg , Jan Dabros , Michael Wu , Tian Ye , Luis Oliveira , Jarkko Nikula Subject: [PATCH 08/11] i2c: designware: Move debug print in i2c_dw_isr() Date: Wed, 26 Oct 2022 15:39:09 +0300 Message-Id: <20221026123912.2833271-9-jarkko.nikula@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221026123912.2833271-1-jarkko.nikula@linux.intel.com> References: <20221026123912.2833271-1-jarkko.nikula@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org It is kind of needless to print interrupt status when code immediately after that finds interrupt was not originating from this device. Therefore move it after spurious interrupt detection. Signed-off-by: Jarkko Nikula --- drivers/i2c/busses/i2c-designware-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c index dce74f8ab171..46e0e6a05506 100644 --- a/drivers/i2c/busses/i2c-designware-master.c +++ b/drivers/i2c/busses/i2c-designware-master.c @@ -775,11 +775,11 @@ static irqreturn_t i2c_dw_isr(int this_irq, void *dev_id) regmap_read(dev->map, DW_IC_ENABLE, &enabled); regmap_read(dev->map, DW_IC_RAW_INTR_STAT, &stat); - dev_dbg(dev->dev, "enabled=%#x stat=%#x\n", enabled, stat); if (!enabled || !(stat & ~DW_IC_INTR_ACTIVITY)) return IRQ_NONE; if (pm_runtime_suspended(dev->dev) || stat == ~0) return IRQ_NONE; + dev_dbg(dev->dev, "enabled=%#x stat=%#x\n", enabled, stat); i2c_dw_irq_handler_master(dev);