From patchwork Tue Jun 28 14:03:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 585709 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 809B7C43334 for ; Tue, 28 Jun 2022 14:03:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347338AbiF1OD3 (ORCPT ); Tue, 28 Jun 2022 10:03:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347336AbiF1OD1 (ORCPT ); Tue, 28 Jun 2022 10:03:27 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CCBD1F618 for ; Tue, 28 Jun 2022 07:03:24 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6BoG-0008KR-Et; Tue, 28 Jun 2022 16:03:20 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o6BoB-003DSx-UA; Tue, 28 Jun 2022 16:03:19 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o6BoE-001gzE-Cy; Tue, 28 Jun 2022 16:03:18 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Pavel Machek Cc: linux-leds@vger.kernel.org, kernel@pengutronix.de, linux-i2c@vger.kernel.org Subject: [PATCH 2/6] leds: lm3697: Remove duplicated error reporting in .remove() Date: Tue, 28 Jun 2022 16:03:08 +0200 Message-Id: <20220628140313.74984-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1304; h=from:subject; bh=Jv1SF4GucMG7dlUgDb+wn5QLjamws7d27rtReMSltaY=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBiuwoJ93Y2xyuLHdEFdevI1uC7TKsgc7car9elRxg4 goimJGeJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYrsKCQAKCRDB/BR4rcrsCZgcCA CKMUBqfl9fo6I9xLxz47A6i4xRxn9iNUQ7/RGpki7O50fvZ9VY1gta/P3qwEKuijMJ4UW8DJOp/KHY 1GQSJRvX8Ute+FwG5XsxRddVHEhqC9Cn5IFuJ3hSYQojBm6OADPvdjYS8gBnbc3HtY2NeeRLecWfba b1kBO2+Tkdj6KT+LTLyFfQYGGjtJ4ieqNfR9SbTlxvQMsQx0ah8Cm2CamBnFBZwU/RaHsHysVJ42On 7npbLMkMEizwRf33D3O+UXE97n2PjjoyJte9VO7wEwYAUMlicxRbkMrsRRnbXGjE12AJn1Xth8M0zP v2VP1ViQmACJv2Vo7/G/y7SAc5RfVp X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i2c@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Returning an error value from an i2c remove callback results in an error message being emitted by the i2c core, but otherwise it doesn't make a difference. The device goes away anyhow and the devm cleanups are called. As lm3697_remove() already emits an error message on failure and the additional error message by the i2c core doesn't add any useful information, don't pass the error value up the stack. Instead continue to clean up and return 0. This patch is a preparation for making i2c remove callbacks return void. Signed-off-by: Uwe Kleine-König Forwarded: id:20220515161227.339514-2-u.kleine-koenig@pengutronix.de --- drivers/leds/leds-lm3697.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/leds/leds-lm3697.c b/drivers/leds/leds-lm3697.c index a8c9322558cc..3ecf90fbc06c 100644 --- a/drivers/leds/leds-lm3697.c +++ b/drivers/leds/leds-lm3697.c @@ -345,10 +345,8 @@ static int lm3697_remove(struct i2c_client *client) ret = regmap_update_bits(led->regmap, LM3697_CTRL_ENABLE, LM3697_CTRL_A_B_EN, 0); - if (ret) { + if (ret) dev_err(dev, "Failed to disable the device\n"); - return ret; - } if (led->enable_gpio) gpiod_direction_output(led->enable_gpio, 0);