diff mbox series

[03/16] i2c: busses: i2c-ali1563: File headers are not good candidates for kernel-doc

Message ID 20210520190105.3772683-4-lee.jones@linaro.org
State New
Headers show
Series Rid W=1 warnings from I2C | expand

Commit Message

Lee Jones May 20, 2021, 7 p.m. UTC 
Fixes the following W=1 kernel build warning(s):

 drivers/i2c/busses/i2c-ali1563.c:24: warning: expecting prototype for i2c(). Prototype was for ALI1563_MAX_TIMEOUT() instead

Cc: Jean Delvare <jdelvare@suse.com>
Cc: Rudolf Marek <r.marek@assembler.cz>
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/i2c/busses/i2c-ali1563.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.31.1

Comments

Jean Delvare May 21, 2021, 10:06 a.m. UTC | #1 
Hi Lee,

On Thu, 20 May 2021 20:00:52 +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/i2c/busses/i2c-ali1563.c:24: warning: expecting prototype for i2c(). Prototype was for ALI1563_MAX_TIMEOUT() instead


Thanks for taking care of the warnings. I agree that a clean W=1 build
would be very nice to have.

> Cc: Jean Delvare <jdelvare@suse.com>

> Cc: Rudolf Marek <r.marek@assembler.cz>

> Cc: linux-i2c@vger.kernel.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> ---

>  drivers/i2c/busses/i2c-ali1563.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c

> index 4d12e3da12f0d..55a9e93fbfeb5 100644

> --- a/drivers/i2c/busses/i2c-ali1563.c

> +++ b/drivers/i2c/busses/i2c-ali1563.c

> @@ -1,5 +1,5 @@

>  // SPDX-License-Identifier: GPL-2.0-only

> -/**

> +/*

>   *	i2c-ali1563.c - i2c driver for the ALi 1563 Southbridge

>   *

>   *	Copyright (C) 2004 Patrick Mochel


Reviewed-by: Jean Delvare <jdelvare@suse.de>


-- 
Jean Delvare
SUSE L3 Support
Wolfram Sang May 27, 2021, 7:30 p.m. UTC | #2 
On Thu, May 20, 2021 at 08:00:52PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/i2c/busses/i2c-ali1563.c:24: warning: expecting prototype for i2c(). Prototype was for ALI1563_MAX_TIMEOUT() instead

> 

> Cc: Jean Delvare <jdelvare@suse.com>

> Cc: Rudolf Marek <r.marek@assembler.cz>

> Cc: linux-i2c@vger.kernel.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Applied to for-current, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c
index 4d12e3da12f0d..55a9e93fbfeb5 100644
--- a/drivers/i2c/busses/i2c-ali1563.c
+++ b/drivers/i2c/busses/i2c-ali1563.c
@@ -1,5 +1,5 @@ 
 // SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
  *	i2c-ali1563.c - i2c driver for the ALi 1563 Southbridge
  *
  *	Copyright (C) 2004 Patrick Mochel