From patchwork Fri Nov 4 10:49:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 80828 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp1080662qge; Fri, 4 Nov 2016 03:48:01 -0700 (PDT) X-Received: by 10.99.1.23 with SMTP id 23mr21170090pgb.37.1478256481669; Fri, 04 Nov 2016 03:48:01 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id lq6si13072887pab.318.2016.11.04.03.48.01; Fri, 04 Nov 2016 03:48:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-i2c-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-i2c-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-i2c-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761348AbcKDKsA (ORCPT + 1 other); Fri, 4 Nov 2016 06:48:00 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:60565 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761275AbcKDKr7 (ORCPT ); Fri, 4 Nov 2016 06:47:59 -0400 Received: from beagle.diag.org (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-08.nifty.com with ESMTP id uA4Aku00012227; Fri, 4 Nov 2016 19:46:57 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com uA4Aku00012227 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1478256417; bh=x5EjIzxx2knK8+zeb5tGBXPdAr7FD45I1sNp0j5i0mY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TOKzMY2Ui7aQiWDtZcGD9x2rfykixGJPsA2H3DIzb22c1atWsXqOTIaDOU8zkGJDI 0i21+meSK6yLqpnRqmOP4b15jA0gFHjIS8uRksaISMhL+Dg8wB3e4FNRpCFCIgH6GD Tc6ZEXAloK+l9FcQKG+ce5MVXiqbJv5PzekEbOxPaeGsX/CEEIGcUZUPaZ5kMORwkr FU6UxBcbR0ACa4+KAtspjCvQXuvmn5wcWq11cksgbjZYy34NgKTFG+BS00sMX3P9sr BVhWSaA5cZF4eRKg31380khnQHhBU6ZiRoweGLvRkm0s7JdNpe6UBti0mql0Z5xy5P yVnX9VYgqXrXw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-i2c@vger.kernel.org Cc: Masahiro Yamada , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Wolfram Sang Subject: [PATCH 2/2] i2c: uniphier-f: rename jump label to follow coding style guideline Date: Fri, 4 Nov 2016 19:49:21 +0900 Message-Id: <1478256561-7709-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1478256561-7709-1-git-send-email-yamada.masahiro@socionext.com> References: <1478256561-7709-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Documentation/CodingStyle recommends to use label names which say what the goto does or why the goto exists. Signed-off-by: Masahiro Yamada --- drivers/i2c/busses/i2c-uniphier-f.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/busses/i2c-uniphier-f.c index b54448e..a154cc9 100644 --- a/drivers/i2c/busses/i2c-uniphier-f.c +++ b/drivers/i2c/busses/i2c-uniphier-f.c @@ -528,7 +528,7 @@ static int uniphier_fi2c_probe(struct platform_device *pdev) if (!clk_rate) { dev_err(dev, "input clock rate should not be zero\n"); ret = -EINVAL; - goto err; + goto disable_clk; } init_completion(&priv->comp); @@ -547,11 +547,11 @@ static int uniphier_fi2c_probe(struct platform_device *pdev) pdev->name, priv); if (ret) { dev_err(dev, "failed to request irq %d\n", irq); - goto err; + goto disable_clk; } ret = i2c_add_adapter(&priv->adap); -err: +disable_clk: if (ret) clk_disable_unprepare(priv->clk);