mbox series

[v1,0/5] i2c: designware: Cleanups (part 2)

Message ID 20240822180411.2298991-1-andriy.shevchenko@linux.intel.com
Headers show
Series i2c: designware: Cleanups (part 2) | expand

Message

Andy Shevchenko Aug. 22, 2024, 5:58 p.m. UTC 
This is the subset of the patches [1] that should not affect any
functionality. Here are:
- consolidation of FW parsing and configuring code 
- some function renaming / dropping
- switching to export namespace

In any case this is Cc'ed to AMD who reported a problem in [1]
presumably in the patch that is *not* included here.

Link: https://lore.kernel.org/linux-i2c/20231207141653.2785124-1-andriy.shevchenko@linux.intel.com/ [1]

Andy Shevchenko (5):
  i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure()
  i2c: designware: Consolidate firmware parsing and configuring code
  i2c: designware: Unify the firmware type checks
  i2c: designware: Move exports to I2C_DW namespaces
  i2c: designware: Remove ->disable() callback

 drivers/i2c/busses/i2c-designware-common.c  | 73 +++++++++++++++++++--
 drivers/i2c/busses/i2c-designware-core.h    | 13 +---
 drivers/i2c/busses/i2c-designware-master.c  |  4 +-
 drivers/i2c/busses/i2c-designware-pcidrv.c  | 18 ++---
 drivers/i2c/busses/i2c-designware-platdrv.c | 53 ++-------------
 drivers/i2c/busses/i2c-designware-slave.c   |  6 +-
 6 files changed, 88 insertions(+), 79 deletions(-)

Comments

Andi Shyti Aug. 23, 2024, 12:45 a.m. UTC | #1 
Hi Andy,

On Thu, Aug 22, 2024 at 08:58:36PM GMT, Andy Shevchenko wrote:
> This is the subset of the patches [1] that should not affect any
> functionality. Here are:
> - consolidation of FW parsing and configuring code 
> - some function renaming / dropping
> - switching to export namespace
> 
> In any case this is Cc'ed to AMD who reported a problem in [1]
> presumably in the patch that is *not* included here.
> 
> Link: https://lore.kernel.org/linux-i2c/20231207141653.2785124-1-andriy.shevchenko@linux.intel.com/ [1]
> 
> Andy Shevchenko (5):
>   i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure()
>   i2c: designware: Consolidate firmware parsing and configuring code
>   i2c: designware: Unify the firmware type checks
>   i2c: designware: Move exports to I2C_DW namespaces
>   i2c: designware: Remove ->disable() callback

I merged these patches in i2c/i2c-host. Normally I leave patches
a bit longer in the list, but they have been reviewed and
discussed.

If there will come some observations from others, we are in time
to change them.

Thanks,
Andi
Andy Shevchenko Aug. 23, 2024, 1:31 p.m. UTC | #2 
On Fri, Aug 23, 2024 at 02:45:58AM +0200, Andi Shyti wrote:
> On Thu, Aug 22, 2024 at 08:58:36PM GMT, Andy Shevchenko wrote:
> > This is the subset of the patches [1] that should not affect any
> > functionality. Here are:
> > - consolidation of FW parsing and configuring code 
> > - some function renaming / dropping
> > - switching to export namespace
> > 
> > In any case this is Cc'ed to AMD who reported a problem in [1]
> > presumably in the patch that is *not* included here.
> > 
> > Link: https://lore.kernel.org/linux-i2c/20231207141653.2785124-1-andriy.shevchenko@linux.intel.com/ [1]
> > 
> > Andy Shevchenko (5):
> >   i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure()
> >   i2c: designware: Consolidate firmware parsing and configuring code
> >   i2c: designware: Unify the firmware type checks
> >   i2c: designware: Move exports to I2C_DW namespaces
> >   i2c: designware: Remove ->disable() callback
> 
> I merged these patches in i2c/i2c-host.

Thank you!

> Normally I leave patches a bit longer in the list, but they have been
> reviewed and discussed.

FWIW, there is no change done to them except rebasing to avoid that suspicious
PM patch to be included.

> If there will come some observations from others, we are in time
> to change them.

Yes, I am here to help.