mbox series

[v5,00/11] i2c: riic: Add support for Renesas RZ/G3S

Message ID 20240820101918.2384635-1-claudiu.beznea.uj@bp.renesas.com
Headers show
Series i2c: riic: Add support for Renesas RZ/G3S | expand

Message

claudiu beznea Aug. 20, 2024, 10:19 a.m. UTC
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Hi,

Series adds I2C support for the Renesas RZ/G3S SoC.

Series is split as follows:
- patch 01-03/12   - add some cleanups on RIIC driver
- patch 04/12      - enable runtime autosuspend support on the RIIC driver
- patch 05/12      - add suspend to RAM support on the RIIC driver
- patch 06/12      - prepares for the addition of fast mode plus
- patch 07/12      - updates the I2C documentation for the RZ/G3S SoC
- patch 08/12      - add fast mode plus support on the RIIC driver
- patches 09-11/11 - device tree support

Thank you,
Claudiu Beznea

Changes in v5:
- collected tags
- addressed review comments

Changes in v4:
- collected tags
- addressed review comments

Changes in v3:
- dropped patch "clk: renesas: r9a08g045: Add clock, reset and power
  domain support for I2C" as it was already integrated
- addressed review comments

Changes in v2:
- change the i2c clock names to match the documentation
- update commit description for patch "i2c: riic: Use temporary
  variable for struct device"
- addressed review comments
- dropped renesas,riic-no-fast-mode-plus DT property and associated code

Claudiu Beznea (11):
  i2c: riic: Use temporary variable for struct device
  i2c: riic: Call pm_runtime_get_sync() when need to access registers
  i2c: riic: Use pm_runtime_resume_and_get()
  i2c: riic: Enable runtime PM autosuspend support
  i2c: riic: Add suspend/resume support
  i2c: riic: Define individual arrays to describe the register offsets
  dt-bindings: i2c: renesas,riic: Document the R9A08G045 support
  i2c: riic: Add support for fast mode plus
  arm64: dts: renesas: r9a08g045: Add I2C nodes
  arm64: dts: renesas: rzg3s-smarc: Enable i2c0 node
  arm64: dts: renesas: rzg3s-smarc-som: Enable i2c1 node

 .../devicetree/bindings/i2c/renesas,riic.yaml |   4 +
 arch/arm64/boot/dts/renesas/r9a08g045.dtsi    |  88 +++++++
 .../boot/dts/renesas/rzg3s-smarc-som.dtsi     |   5 +
 arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi  |   7 +
 drivers/i2c/busses/i2c-riic.c                 | 225 ++++++++++++------
 5 files changed, 261 insertions(+), 68 deletions(-)

Comments

Andi Shyti Aug. 21, 2024, 2:12 p.m. UTC | #1
Hi Claudiu,

> Claudiu Beznea (11):
>   i2c: riic: Use temporary variable for struct device
>   i2c: riic: Call pm_runtime_get_sync() when need to access registers
>   i2c: riic: Use pm_runtime_resume_and_get()
>   i2c: riic: Enable runtime PM autosuspend support
>   i2c: riic: Add suspend/resume support
>   i2c: riic: Define individual arrays to describe the register offsets
>   dt-bindings: i2c: renesas,riic: Document the R9A08G045 support
>   i2c: riic: Add support for fast mode plus

Up to here, first 8 patches, merged to i2c/i2c-host.

Thanks,
Andi
Geert Uytterhoeven Aug. 23, 2024, 11:42 a.m. UTC | #2
On Tue, Aug 20, 2024 at 12:19 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> The Renesas RZ/G3S has 4 I2C channels. Add DT nodes for it.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.12.

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven Aug. 23, 2024, 11:59 a.m. UTC | #3
On Tue, Aug 20, 2024 at 12:19 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Enable i2c1 node.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.12.

Gr{oetje,eeting}s,

                        Geert
Wolfram Sang Sept. 14, 2024, 8:45 p.m. UTC | #4
On Wed, Aug 21, 2024 at 04:12:27PM +0200, Andi Shyti wrote:
> Hi Claudiu,
> 
> > Claudiu Beznea (11):
> >   i2c: riic: Use temporary variable for struct device
> >   i2c: riic: Call pm_runtime_get_sync() when need to access registers
> >   i2c: riic: Use pm_runtime_resume_and_get()
> >   i2c: riic: Enable runtime PM autosuspend support
> >   i2c: riic: Add suspend/resume support
> >   i2c: riic: Define individual arrays to describe the register offsets
> >   dt-bindings: i2c: renesas,riic: Document the R9A08G045 support
> >   i2c: riic: Add support for fast mode plus
> 
> Up to here, first 8 patches, merged to i2c/i2c-host.

It took a while but I needed to get my Genmai-board booting again. It
does now and I could test these changes on r7s72100 (RZA1H). Reading,
writing, suspend/resume, works like expected. No regressions
experienced. So, for the record.

Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>