| Message ID | 20240808183527.3950120-1-mstrodl@csh.rit.edu |
|---|---|
| Headers | show |
| Series | Add support for Congatec CGEB BIOS interface | expand |
Hi Mary, just skimmed through fast... > + dev_dbg(&adapter->dev, > + "%s: rd: %p/%ld wr: %p/%ld flags: 0x%08lx %s\n", > + __func__, rdbuf, rdlen, raw_wrbuf, wrlen + 1, > + flags, > + msgs[i].flags & I2C_M_RD ? "READ" : "WRITE"); please mind the alignment: align everuthyng under the "(". ... > + ret = i2c_add_adapter(&priv->adapter); > + if (ret < 0) { > + dev_err(&pdev->dev, "registration failed\n"); > + return ret; please use dev_err_probe(); Andi
The following series adds support for the Congatec CGEB interface found on some Congatec x86 boards. The CGEB interface is a BIOS interface which provides access to onboard peripherals like I2C busses and watchdogs. It works by mapping BIOS code and searching for magic values which specify the entry points to the CGEB call. The CGEB call is an API provided by the BIOS which provides access to the functions in an ioctl like fashion. At the request of some folks the first time I sent this series out, CGEB has a userspace component which runs the x86 blob (rather than running it directly in the kernel), which sends requests back and forth using the cn_netlink API. You can find a reference implementation of the userspace helper here: https://github.com/Mstrodl/cgeb-helper I didn't get an answer when I asked where the userspace component should live, so I didn't put a ton of work into getting the helper up to snuff since similar userspace helpers (like v86d) are not in-tree. If folks would like the helper in-tree, that's fine too. Changelog: v2: * Moved CGEB code snippet execution into userspace v3: * `checkpatch` pass * Should I add the driver files to MAINTAINERS? I'm not sure what the norm is there... * `sparse` pass * I'm not sure there's a good way to keep the __iomem marker around while not making the struct fields really inconvenient to access, so I just cast them away which causes a sparse warning. I figure it's probably okay since this driver is x86-specific anyways? Let me know if this is an issue and what the preferred approach is. This series is based on the excellent work of Sascha Hauer and Christian Gmeiner. You can find their original work here: http://patchwork.ozlabs.org/patch/219756/ http://patchwork.ozlabs.org/patch/219755/ http://patchwork.ozlabs.org/patch/219757/ http://patchwork.ozlabs.org/patch/483262/ http://patchwork.ozlabs.org/patch/483264/ http://patchwork.ozlabs.org/patch/483261/ http://patchwork.ozlabs.org/patch/483263/ Mary Strodl (1): x86: Add basic support for the Congatec CGEB BIOS interface Sascha Hauer (1): i2c: Add Congatec CGEB I2C driver drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-congatec-cgeb.c | 190 ++++ drivers/mfd/Kconfig | 10 + drivers/mfd/Makefile | 1 + drivers/mfd/congatec-cgeb.c | 1138 ++++++++++++++++++++++++ include/linux/mfd/congatec-cgeb.h | 112 +++ include/uapi/linux/connector.h | 4 +- 8 files changed, 1465 insertions(+), 1 deletion(-) create mode 100644 drivers/i2c/busses/i2c-congatec-cgeb.c create mode 100644 drivers/mfd/congatec-cgeb.c create mode 100644 include/linux/mfd/congatec-cgeb.h