| Message ID | 20240627-piix4-spd-v2-0-617ce47b8ff4@weissschuh.net |
|---|---|
| Headers | show |
| Series | i2c: smbus cleanups and SPD support for piix4 | expand |
Jul 4, 2024 23:56:45 Andi Shyti <andi.shyti@kernel.org>: > Hi Thomas, > > ... > >> Thomas Weißschuh (4): >> i2c: smbus: only limit max banks to eight >> i2c: smbus: probe SPDs on a best-effort basis >> i2c: smbus: drop warning about muxed segments requirement > > These three patches are shuffling around the code, > adding/removing/moving the same bits. Can we squash them to a > single patch? IMO they are doing different things, but I'll squash them for the next submission.
Patches 1-3 are preparation patches, with patch 1 being a fix. Patch 4 is the actual change to piix4. Patch 3 drops the warning about muxed busses. I didn't feel that the warning only would warrant the additional complexity it introduces with multiple callers of i2c_register_spd(). If other feel different, maybe a more generic warning/info or a source code comment would suffice. On a machine with 32 slots of which 16 are populated only the first 8 slots are addressable, half of which are empty. Unfortunately I couldn't run a custom kernel for testing. But manually instantiating ee1004 devices worked as expected, so the proposed changes should also work. Tested with spd5118 and two DIMMs. Guenter, I dropped your Tested-by as the piix4 patch changed. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- Changes in v2: - Add new i2c-smbus prep patches - Only register SPD for port 0 - Link to v1: https://lore.kernel.org/r/20240530-piix4-spd-v1-1-9cbf1abebf41@weissschuh.net --- Thomas Weißschuh (4): i2c: smbus: only limit max banks to eight i2c: smbus: probe SPDs on a best-effort basis i2c: smbus: drop warning about muxed segments requirement i2c: piix4: Register SPDs drivers/i2c/busses/Kconfig | 1 + drivers/i2c/busses/i2c-piix4.c | 4 ++++ drivers/i2c/i2c-smbus.c | 15 ++++----------- 3 files changed, 9 insertions(+), 11 deletions(-) --- base-commit: 4e2600bca665197acb537ae63f24d3075e6bac8b change-id: 20240530-piix4-spd-39c156b22959 Best regards,