| Message ID | 20240425070948.25788-1-jose.sanbuenaventura@analog.com |
|---|---|
| Headers | show |
| Series | Add adm1281 support | expand |
On Thu, Apr 25, 2024 at 10:52:03AM -0700, Guenter Roeck wrote: > On 4/25/24 00:09, Jose Ramon San Buenaventura wrote: > > Adding support for adm1281 which is similar to adm1275 > > > > Signed-off-by: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.com> > > Patch is fine, but we'll need to wait for Conor's feedback > regarding the compatible fallback before I can apply it. Oh, I didn't realise you were waiting for me. I had deleted the thread from my queue given I had already acked the patch. I'm not really a fan of the warn when IDs don't match thing though, seems a bit unhelpful, unless you've running into scenarios where the firmware tells you there's a device present but actually there's some other incompatible one.
On 4/26/24 10:01, Conor Dooley wrote: > On Thu, Apr 25, 2024 at 10:52:03AM -0700, Guenter Roeck wrote: >> On 4/25/24 00:09, Jose Ramon San Buenaventura wrote: >>> Adding support for adm1281 which is similar to adm1275 >>> >>> Signed-off-by: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.com> >> >> Patch is fine, but we'll need to wait for Conor's feedback >> regarding the compatible fallback before I can apply it. > > Oh, I didn't realise you were waiting for me. I had deleted the thread > from my queue given I had already acked the patch. > > I'm not really a fan of the warn when IDs don't match thing though, > seems a bit unhelpful, unless you've running into scenarios where the > firmware tells you there's a device present but actually there's some > other incompatible one. That is pretty much what we do, because many of the chips supported by the driver are not or not fully compatible to each other. Sure, we could add more information about fully compatible chips, but in my opinion that would just add complexity to the driver for little if any gain. Thanks, Guenter
On Thu, Apr 25, 2024 at 03:09:48PM +0800, Jose Ramon San Buenaventura wrote: > Adding support for adm1281 which is similar to adm1275 > > Signed-off-by: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.com> Applied. Thanks, Guenter
CHANGELOG: v2 -> v3: - removed extra boolean member in adm1275_data structure - refactored commit message v1 -> v2: - removed STATUS_CML case in read_byte_data function Jose Ramon San Buenaventura (2): dt-bindings: hwmon: adm1275: add adm1281 hwmon: pmbus: adm1275: add adm1281 support .../devicetree/bindings/hwmon/adi,adm1275.yaml | 4 +++- Documentation/hwmon/adm1275.rst | 14 +++++++++++--- drivers/hwmon/pmbus/Kconfig | 4 ++-- drivers/hwmon/pmbus/adm1275.c | 7 +++++-- 4 files changed, 21 insertions(+), 8 deletions(-) base-commit: 96fca68c4fbf77a8185eb10f7557e23352732ea2