| Message ID | 20240213124847.672084-1-jarkko.nikula@linux.intel.com |
|---|---|
| Headers | show |
| Series | i2c: designware: Generic polling mode code | expand |
On Tue, Feb 13, 2024 8:49 PM, Jarkko Nikula wrote: > Hi Jiawen, Sanket and Basavaraj > > I hope you could give a quick test to this patchset to see it won't cause > regression on your HW. This is mostly the same than the first version what > Jiawen tested earlier but in this 3rd version I decided to drop semphore > touching code patches from v2 due they being out of scope and fix a few > things noted by Andy. > > Changes are in the patch 3/6 with two minor fixes to comments while moving > them and the patch 6/6 where i2c_dw_wait_transfer() is slightly modified > by Andy's suggestion plus I decided to remove one comment which became > unclear after this patch. Hi Jarkko, I've been testing the v3 patch series on Wangxun 10Gb NIC, it works well, too. Thanks! Tested-by: Jiawen Wu <jiawenwu@trustnetic.com>
Hi On 2/18/24 11:19, Jiawen Wu wrote: > On Tue, Feb 13, 2024 8:49 PM, Jarkko Nikula wrote: >> Hi Jiawen, Sanket and Basavaraj >> >> I hope you could give a quick test to this patchset to see it won't cause >> regression on your HW. This is mostly the same than the first version what >> Jiawen tested earlier but in this 3rd version I decided to drop semphore >> touching code patches from v2 due they being out of scope and fix a few >> things noted by Andy. >> >> Changes are in the patch 3/6 with two minor fixes to comments while moving >> them and the patch 6/6 where i2c_dw_wait_transfer() is slightly modified >> by Andy's suggestion plus I decided to remove one comment which became >> unclear after this patch. > > Hi Jarkko, > > I've been testing the v3 patch series on Wangxun 10Gb NIC, it works well, too. > Thanks! > > Tested-by: Jiawen Wu <jiawenwu@trustnetic.com> > Andy: Was this set ok in your point of view now?
On Fri, Feb 23, 2024 at 05:09:37PM +0200, Jarkko Nikula wrote: > On 2/18/24 11:19, Jiawen Wu wrote: > > On Tue, Feb 13, 2024 8:49 PM, Jarkko Nikula wrote: > > > Hi Jiawen, Sanket and Basavaraj > > > > > > I hope you could give a quick test to this patchset to see it won't cause > > > regression on your HW. This is mostly the same than the first version what > > > Jiawen tested earlier but in this 3rd version I decided to drop semphore > > > touching code patches from v2 due they being out of scope and fix a few > > > things noted by Andy. > > > > > > Changes are in the patch 3/6 with two minor fixes to comments while moving > > > them and the patch 6/6 where i2c_dw_wait_transfer() is slightly modified > > > by Andy's suggestion plus I decided to remove one comment which became > > > unclear after this patch. > > > > Hi Jarkko, > > > > I've been testing the v3 patch series on Wangxun 10Gb NIC, it works well, too. > > Thanks! > > > > Tested-by: Jiawen Wu <jiawenwu@trustnetic.com> > > > Andy: Was this set ok in your point of view now? Yes, I hoped that Andi applies it earlier last week or so.
Hi On Tue, 13 Feb 2024 14:48:41 +0200, Jarkko Nikula wrote: > I hope you could give a quick test to this patchset to see it won't cause > regression on your HW. This is mostly the same than the first version what > Jiawen tested earlier but in this 3rd version I decided to drop semphore > touching code patches from v2 due they being out of scope and fix a few > things noted by Andy. > > Changes are in the patch 3/6 with two minor fixes to comments while moving > them and the patch 6/6 where i2c_dw_wait_transfer() is slightly modified > by Andy's suggestion plus I decided to remove one comment which became > unclear after this patch. > > [...] Applied to i2c/i2c-host on git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git Thank you, Andi Patches applied =============== [1/6] i2c: designware: Uniform initialization flow for polling mode commit: 535677e44d57a31e1363529b5ecddb92653d7136 [2/6] i2c: designware: Do not enable interrupts shortly in polling mode commit: 64b6426a6e97a95c044fd2fff3f0adf7c1edb60c [3/6] i2c: designware: Use accessors to DW_IC_INTR_MASK register commit: 04c71da4a9f4eef94bec153ed667d105dacffda3 [4/6] i2c: designware: Move interrupt handling functions before i2c_dw_xfer() commit: bd002efaa16e4cfffc25db2d9c4669aaa2b43646 [5/6] i2c: designware: Fix RX FIFO depth define on Wangxun 10Gb NIC commit: c94612a72ac87b0337a0d85b9263266776ed4190 [6/6] i2c: designware: Implement generic polling mode code for Wangxun 10Gb NIC commit: 197ecadad842855437a36ffc161648418ae02a97
Hi Jiawen, Sanket and Basavaraj I hope you could give a quick test to this patchset to see it won't cause regression on your HW. This is mostly the same than the first version what Jiawen tested earlier but in this 3rd version I decided to drop semphore touching code patches from v2 due they being out of scope and fix a few things noted by Andy. Changes are in the patch 3/6 with two minor fixes to comments while moving them and the patch 6/6 where i2c_dw_wait_transfer() is slightly modified by Andy's suggestion plus I decided to remove one comment which became unclear after this patch. v2: https://lore.kernel.org/linux-i2c/20240206145158.227254-1-jarkko.nikula@linux.intel.com/ v1: https://lore.kernel.org/linux-i2c/20240131141653.2689260-1-jarkko.nikula@linux.intel.com/ Jarkko Nikula (6): i2c: designware: Uniform initialization flow for polling mode i2c: designware: Do not enable interrupts shortly in polling mode i2c: designware: Use accessors to DW_IC_INTR_MASK register i2c: designware: Move interrupt handling functions before i2c_dw_xfer() i2c: designware: Fix RX FIFO depth define on Wangxun 10Gb NIC i2c: designware: Implement generic polling mode code for Wangxun 10Gb NIC drivers/i2c/busses/i2c-designware-common.c | 2 +- drivers/i2c/busses/i2c-designware-core.h | 23 +- drivers/i2c/busses/i2c-designware-master.c | 419 +++++++++----------- drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +- drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- 5 files changed, 208 insertions(+), 240 deletions(-)