mbox series

[v4,0/3] Add atomic transfers to s3c24xx i2c driver

Message ID 20231108164354.712406-1-m.szyprowski@samsung.com
Headers show
Series Add atomic transfers to s3c24xx i2c driver | expand

Message

Marek Szyprowski Nov. 8, 2023, 4:43 p.m. UTC
Dear All,

This patchset adds support for atomic transfers, which has been added to
the i2c core recently by the commit 63b96983a5dd ("i2c: core: introduce
callbacks for atomic transfers") to hide warnings observed during system
reboot and power-off. Almost everything needed for that was already in
the driver as so called polling mode. Unfortunately, that polling mode
has been tested only with single message, write transfers so far and it
turned out that it doesn't work well with read and multi-message
transfers, so first it had to be fixed.

Best regards,
Marek Szyprowski


Changelog:
v4:
- added a comment about the delay value

v3:
- fixed style issue pointed by Andi, extended commit message

v2:
- updated and extended commit messages


Patch summary:

Marek Szyprowski (3):
  i2c: s3c24xx: fix read transfers in polling mode
  i2c: s3c24xx: fix transferring more than one message in polling mode
  i2c: s3c24xx: add support for atomic transfers

 drivers/i2c/busses/i2c-s3c2410.c | 61 +++++++++++++++++++++-----------
 1 file changed, 40 insertions(+), 21 deletions(-)

Comments

Wolfram Sang Dec. 19, 2023, 5 p.m. UTC | #1
On Wed, Nov 08, 2023 at 05:43:51PM +0100, Marek Szyprowski wrote:
> Dear All,
> 
> This patchset adds support for atomic transfers, which has been added to
> the i2c core recently by the commit 63b96983a5dd ("i2c: core: introduce
> callbacks for atomic transfers") to hide warnings observed during system
> reboot and power-off. Almost everything needed for that was already in
> the driver as so called polling mode. Unfortunately, that polling mode
> has been tested only with single message, write transfers so far and it
> turned out that it doesn't work well with read and multi-message
> transfers, so first it had to be fixed.
> 
> Best regards,
> Marek Szyprowski
> 
> 
> Changelog:
> v4:
> - added a comment about the delay value
> 
> v3:
> - fixed style issue pointed by Andi, extended commit message
> 
> v2:
> - updated and extended commit messages
> 
> 
> Patch summary:
> 
> Marek Szyprowski (3):
>   i2c: s3c24xx: fix read transfers in polling mode
>   i2c: s3c24xx: fix transferring more than one message in polling mode
>   i2c: s3c24xx: add support for atomic transfers
> 

Applied to for-next, thanks!