mbox series

[v2,0/4] Add interconnects to QUPs on SM8250

Message ID 20230703-topic-8250_qup_icc-v2-0-9ba0a9460be2@linaro.org
Headers show
Series Add interconnects to QUPs on SM8250 | expand

Message

Konrad Dybcio July 3, 2023, 8:15 p.m. UTC
SM8250 (like SM8150 but unlike all other QUP-equipped SoCs) doesn't
provide a qup-core path. Adjust the bindings and drivers as necessary,
and then describe the icc paths in the device tree. This makes it possible
for interconnect sync_state succeed so long as you don't use UFS.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Changes in v2:
- drop everything, fix icc instead of messing with bindings
- Link to v1: https://lore.kernel.org/r/20230703-topic-8250_qup_icc-v1-0-fea39aa07525@linaro.org

---
Konrad Dybcio (4):
      dt-bindings: interconnect: qcom,rpmh: Add SM8250 QUP virt
      dt-bindings: interconnect: qcom,sm8250: Add QUP virt
      interconnect: qcom: sm8250: Fix QUP0 nodes
      arm64: dts: qcom: sm8250: Add interconnects and power-domains to QUPs

 .../bindings/interconnect/qcom,rpmh.yaml           |  18 +-
 arch/arm64/boot/dts/qcom/sm8250.dtsi               | 286 +++++++++++++++++++++
 drivers/interconnect/qcom/sm8250.c                 |  74 +++++-
 drivers/interconnect/qcom/sm8250.h                 |   6 +
 include/dt-bindings/interconnect/qcom,sm8250.h     |   7 +
 5 files changed, 384 insertions(+), 7 deletions(-)
---
base-commit: 296d53d8f84ce50ffaee7d575487058c8d437335
change-id: 20230703-topic-8250_qup_icc-61768a34c7ec

Best regards,

Comments

Bjorn Andersson July 18, 2023, 4:41 a.m. UTC | #1
On Mon, Jul 03, 2023 at 10:15:27PM +0200, Konrad Dybcio wrote:
> The QUP0 BCM relates to some internal property of the QUPs, and should
> be configured independently of the path to the QUP. In line with other
> platforms expose QUP_CORE endpoints in order allow this configuration.
> 
> Fixes: 6df5b349491e ("interconnect: qcom: Add SM8250 interconnect provider driver")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn
Bjorn Andersson Sept. 19, 2023, 11:07 p.m. UTC | #2
On Mon, 03 Jul 2023 22:15:24 +0200, Konrad Dybcio wrote:
> SM8250 (like SM8150 but unlike all other QUP-equipped SoCs) doesn't
> provide a qup-core path. Adjust the bindings and drivers as necessary,
> and then describe the icc paths in the device tree. This makes it possible
> for interconnect sync_state succeed so long as you don't use UFS.
> 
> 

Applied, thanks!

[4/4] arm64: dts: qcom: sm8250: Add interconnects and power-domains to QUPs
      commit: 86a9264b6c56c9eee6dd5c8733f92afd3f58ce98

Best regards,