mbox series

[v2,00/12] i2c: designware: Slave fixes and generic cleanups

Message ID 20221102131125.421512-1-jarkko.nikula@linux.intel.com
Headers show
Series i2c: designware: Slave fixes and generic cleanups | expand

Message

Jarkko Nikula Nov. 2, 2022, 1:11 p.m. UTC
Hi

Version 2 of the patchset I sent last week:
https://www.spinics.net/lists/linux-i2c/msg58933.html

Changes address the comments Andy made and is rebased on top of current
i2c/for-next.

Luis Oliveira is not Cc'ed since I forgot his address is no longer working.

Changes:
- Patch 07/12 is using GENMASK(31, 0) instead of ~0
- Patch 10/12 Two leftovers from v1 removed and updated commit log
- Patch 11/12 Removed accidental "struct i2c_bus_recovery_info rinfo" missalign
- Patch 12/12 New patch commenting ASCII values of register value constants

Jarkko Nikula (12):
  i2c: designware: Fix slave state machine for sequential reads
  i2c: designware: Empty receive FIFO in slave interrupt handler
  i2c: designware: Define software status flags with BIT()
  i2c: designware: Remove needless initializations from
    i2c_dw_reg_slave()
  i2c: designware: Remove unused completion code from
    i2c-designware-slave
  i2c: designware: Simplify slave interrupt handler nesting
  i2c: designware: Do not process interrupt when device is suspended
  i2c: designware: Move debug print in i2c_dw_isr()
  i2c: designware: Simplify master interrupt handler nesting
  i2c: designware: Remove common i2c_dw_disable_int()
  i2c: designware: Align defines in i2c-designware-core.h
  i2c: designware: Add comment to custom register value constants

 drivers/i2c/busses/i2c-designware-common.c |   5 -
 drivers/i2c/busses/i2c-designware-core.h   | 235 ++++++++++-----------
 drivers/i2c/busses/i2c-designware-master.c |  44 ++--
 drivers/i2c/busses/i2c-designware-slave.c  |  77 +++----
 4 files changed, 163 insertions(+), 198 deletions(-)

base-commit: d28187f693ac5222d3b30955415143cd8e3b5edf

Comments

Jarkko Nikula Nov. 7, 2022, 11:55 a.m. UTC | #1
On 11/2/22 16:28, Andy Shevchenko wrote:
> On Wed, Nov 02, 2022 at 03:11:13PM +0200, Jarkko Nikula wrote:
>> Hi
>>
>> Version 2 of the patchset I sent last week:
>> https://www.spinics.net/lists/linux-i2c/msg58933.html
>>
>> Changes address the comments Andy made and is rebased on top of current
>> i2c/for-next.
>>
>> Luis Oliveira is not Cc'ed since I forgot his address is no longer working.
> 
> All look good to me,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
I'll add that to 3rd version where I have fixed the typo in the patch 
9/12 and updated 12/12.

Jarkko