| Message ID | 20220531135026.238475-1-fparent@baylibre.com |
|---|---|
| Headers | show |
| Series | Add support for MT8365 EVK board | expand |
On 31/05/2022 15:50, Fabien Parent wrote: > This patch series adds support for the MT8365 EVK board. > > This series has dependencies on the following series: > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646256 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646091 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646083 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646081 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646076 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646068 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646020 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646052 > https://lore.kernel.org/r/20220504091923.2219-2-rex-bc.chen@mediatek.com > https://lore.kernel.org/r/20220512062622.31484-2-chunfeng.yun@mediatek.com > https://lore.kernel.org/r/20220512062622.31484-1-chunfeng.yun@mediatek.com > https://lore.kernel.org/r/20220524115019.97246-1-angelogioacchino.delregno@collabora.com > https://lore.kernel.org/all/20220127015857.9868-1-biao.huang@mediatek.com/ Eh... and how we are supposed to test or apply this? Such dependencies could mean none of automated tools will pick it up, so your patchset has to wait till dependencies got merged. Best regards, Krzysztof
On 31/05/2022 15:50, Fabien Parent wrote: > Add binding documentation for the MT8365 I2C controllers. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml > index 16a1a3118204..a6fe0d8b0cbe 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml > @@ -43,6 +43,10 @@ properties: > - enum: > - mediatek,mt8195-i2c > - const: mediatek,mt8192-i2c > + - items: > + - enum: > + - mediatek,mt8365-i2c > + - const: mediatek,mt8168-i2c Order entries by last item, so this goes before mt8192 > > reg: > items: Best regards, Krzysztof
On 31/05/2022 15:50, Fabien Parent wrote: > Add MMC bindings for MT8365 bindings. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > index 2a2e9fa8c188..3195b80ef057 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -38,6 +38,9 @@ properties: > - items: > - const: mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > + - items: > + - const: mediatek,mt8365-mmc You code it so inconsistently... It's one patchset but each patch doing the same thing differently. Please put it under enum in entry above. Best regards, Krzysztof
On 31/05/2022 15:50, Fabien Parent wrote: > Add binding documentation in order to support the MT8365 SoC. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > Documentation/devicetree/bindings/dma/mediatek,uart-dma.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 31/05/2022 15:50, Fabien Parent wrote: > Add bindings documentation for the efuse driver on MT8365 SoC. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > index 7c7233e29ecf..444875264493 100644 > --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > @@ -32,6 +32,7 @@ properties: > - mediatek,mt8192-efuse > - mediatek,mt8195-efuse > - mediatek,mt8516-efuse > + - mediatek,mt8365-efuse Order please Best regards, Krzysztof
On 31/05/2022 15:50, Fabien Parent wrote: > Add binding documentation for the MT8365 SoC. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 31/05/2022 15:50, Fabien Parent wrote: > Add binding documentation for the MT8365 SoC. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > Documentation/devicetree/bindings/serial/mediatek,uart.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 31/05/2022 15:50, Fabien Parent wrote: > Add binding documentation for the MT8365 SoC. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 31/05/2022 15:50, Fabien Parent wrote: > Add device-tree for the MT6357 PMIC. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > arch/arm64/boot/dts/mediatek/mt6357.dtsi | 272 +++++++++++++++++++++++ > 1 file changed, 272 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt6357.dtsi > (...) > + > + mt6357rtc: mt6357rtc { Generic node names, so "rtc". > + compatible = "mediatek,mt6357-rtc", > + "mediatek,mt6358-rtc"; > + }; > + > + mt6357keys: mt6357keys { Generic node names. > + compatible = "mediatek,mt6357-keys"; > + }; > + }; > +}; Best regards, Krzysztof
On 31/05/2022 15:50, Fabien Parent wrote: > Add device-tree for the MT8365-EVK board. The MT8365 EVK board > has the following IOs: > * DPI <-> HDMI bridge and HDMI connector. > * 2 audio jack > * 1 USB Type-A Host port > * 2 UART to USB port > * 1 battery connector > * 1 eMMC > * 1 SD card > * 2 camera connectors > * 1 M.2 slot for connectivity > * 1 DSI connector + touchscreen connector > * RPI compatible header > * 1 Ethernet port Thank you for your patch. There is something to discuss/improve. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > arch/arm64/boot/dts/mediatek/Makefile | 1 + > arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 578 ++++++++++++++++++++ > 2 files changed, 579 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-evk.dts > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index c7d4636a2cb7..02a9f784358e 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -40,4 +40,5 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-pumpkin.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-demo.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-evb.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb > diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > new file mode 100644 > index 000000000000..8f472caa06a3 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > @@ -0,0 +1,578 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2021 BayLibre, SAS. > + * Author: Fabien Parent <fparent@baylibre.com> > + */ > + > +/dts-v1/; > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > +#include <dt-bindings/pinctrl/mt8365-pinfunc.h> > +#include "mt8365.dtsi" > +#include "mt6357.dtsi" > + > +/ { > + model = "MediaTek MT8365 Open Platform EVK"; > + compatible = "mediatek,mt8365-evk", "mediatek,mt8365"; > + > + aliases { > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:921600n8"; > + }; > + > + connector { > + compatible = "hdmi-connector"; > + label = "hdmi"; > + type = "a"; > + > + port { > + hdmi_connector_in: endpoint { > + remote-endpoint = <&hdmi_connector_out>; > + }; > + }; > + }; > + > + firmware { > + optee { > + compatible = "linaro,optee-tz"; > + method = "smc"; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + input-name = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_keys>; > + > + volume-up { key-volume-up, volume-up-key or key-0 > + gpios = <&pio 24 GPIO_ACTIVE_LOW>; > + label = "volume_up"; > + linux,code = <KEY_VOLUMEUP>; > + wakeup-source; > + debounce-interval = <15>; > + }; > + }; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0 0x40000000 0 0xc0000000>; > + }; > + > + usb_otg_vbus: regulator-2 { > + compatible = "regulator-fixed"; > + regulator-name = "otg_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&pio 16 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + /* 12 MiB reserved for OP-TEE (BL32) > + * +-----------------------+ 0x43e0_0000 > + * | SHMEM 2MiB | > + * +-----------------------+ 0x43c0_0000 > + * | | TA_RAM 8MiB | > + * + TZDRAM +--------------+ 0x4340_0000 > + * | | TEE_RAM 2MiB | > + * +-----------------------+ 0x4320_0000 > + */ > + optee_reserved: optee@43200000 { > + no-map; > + reg = <0 0x43200000 0 0x00c00000>; > + }; > + }; > +}; > + > +&cpu0 { > + proc-supply = <&mt6357_vproc_reg>; > + sram-supply = <&mt6357_vsram_proc_reg>; > +}; > + > +&cpu1 { > + proc-supply = <&mt6357_vproc_reg>; > + sram-supply = <&mt6357_vsram_proc_reg>; > +}; > + > +&cpu2 { > + proc-supply = <&mt6357_vproc_reg>; > + sram-supply = <&mt6357_vsram_proc_reg>; > +}; > + > +&cpu3 { > + proc-supply = <&mt6357_vproc_reg>; > + sram-supply = <&mt6357_vsram_proc_reg>; > +}; > + > +&dpi0 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&dpi_func_pins>; > + pinctrl-1 = <&dpi_idle_pins>; > + assigned-clocks = <&topckgen CLK_TOP_DPI0_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_LVDSPLL_D4>; > + > + /* > + * Ethernet and HDMI are sharing pins. > + * Only one can be enabled at a time and require the physical switch > + * SW2101 to be set on DPI position > + */ > + status = "okay"; > + > + port { > + dpi_out: endpoint { > + remote-endpoint = <&it66121_in>; > + }; > + }; > +}; > + > +ðernet { > + pinctrl-names = "default"; > + pinctrl-0 = <ðernet_pins>; > + phy-handle = <ð_phy>; > + phy-mode = "rmii"; > + mac-address = [00 00 00 00 00 00]; > + > + /* > + * Ethernet and HDMI are sharing pins. > + * Only one can be enabled at a time and require the physical switch > + * SW2101 to be set on LAN position > + */ > + status = "disabled"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + eth_phy: ethernet-phy@0 { > + reg = <0>; > + }; > + }; > +}; > + > +&i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > + clock-frequency = <100000>; > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; You defined address/size in DTSI. > + > + it66121hdmitx: hdmi@4c { > + compatible = "ite,it66121"; > + pinctrl-names = "default"; > + pinctrl-0 = <&ite_pins>; > + vcn33-supply = <&mt6357_vibr_reg>; > + vcn18-supply = <&mt6357_vsim2_reg>; > + vrf12-supply = <&mt6357_vrf12_reg>; > + reset-gpios = <&pio 69 GPIO_ACTIVE_LOW>; > + interrupts-extended = <&pio 68 IRQ_TYPE_LEVEL_LOW>; > + #sound-dai-cells = <0>; > + reg = <0x4c>; Put reg after compatible. > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + it66121_in: endpoint { > + bus-width = <12>; > + remote-endpoint = <&dpi_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + hdmi_connector_out: endpoint { > + remote-endpoint = <&hdmi_connector_in>; > + }; > + }; > + }; > + }; > +}; > + > +&mmc0 { > + status = "okay"; Status okay goes to the end. In some nodes you keep that style, in some not. Confusing. > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&mmc0_pins_default>; > + pinctrl-1 = <&mmc0_pins_uhs>; > + bus-width = <8>; > + max-frequency = <200000000>; > + cap-mmc-highspeed; > + mmc-hs200-1_8v; > + mmc-hs400-1_8v; > + cap-mmc-hw-reset; > + no-sdio; > + no-sd; > + hs400-ds-delay = <0x12012>; > + vmmc-supply = <&mt6357_vemc_reg>; > + vqmmc-supply = <&mt6357_vio18_reg>; > + assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL>; > + non-removable; > +}; > + > +&mmc1 { > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&mmc1_pins_default>; > + pinctrl-1 = <&mmc1_pins_uhs>; > + cd-gpios = <&pio 76 GPIO_ACTIVE_LOW>; > + bus-width = <4>; > + max-frequency = <200000000>; > + cap-sd-highspeed; > + sd-uhs-sdr50; > + sd-uhs-sdr104; > + vmmc-supply = <&mt6357_vmch_reg>; > + vqmmc-supply = <&mt6357_vio18_reg>; > + status = "okay"; > +}; > + > +&mt6357_pmic { > + interrupt-parent = <&pio>; > + interrupts = <145 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-controller; > + #interrupt-cells = <2>; > +}; > + > +&mt6357_vibr_reg { > + regulator-always-on; > +}; > + > +/* Needed by MSDC1 */ > +&mt6357_vmc_reg { > + regulator-always-on; > +}; > + > +&mt6357_vrf12_reg { > + regulator-always-on; > +}; > + > +&mt6357_vsim2_reg { > + regulator-always-on; > +}; > + > +&mt6357keys { > + power-key { > + label = "power"; > + linux,keycodes = <KEY_POWER>; > + wakeup-source; > + }; > + > + volume-down { volume-down-key > + label = "volume_down"; > + linux,keycodes = <KEY_VOLUMEDOWN>; Best regards, Krzysztof
On Tue, 31 May 2022 15:50:09 +0200, Fabien Parent wrote: > This patch series adds support for the MT8365 EVK board. > > This series has dependencies on the following series: > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646256 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646091 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646083 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646081 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646076 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646068 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646020 > https://patchwork.kernel.org/project/linux-mediatek/list/?series=646052 > https://lore.kernel.org/r/20220504091923.2219-2-rex-bc.chen@mediatek.com > https://lore.kernel.org/r/20220512062622.31484-2-chunfeng.yun@mediatek.com > https://lore.kernel.org/r/20220512062622.31484-1-chunfeng.yun@mediatek.com > https://lore.kernel.org/r/20220524115019.97246-1-angelogioacchino.delregno@collabora.com > https://lore.kernel.org/all/20220127015857.9868-1-biao.huang@mediatek.com/ > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [09/17] dt-bindings: spi: mt65xx: add MT8365 SoC bindings commit: 901fc8e8079e401f3240006cab6629e65579701c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark