| Message ID | 20210512112024.1651757-1-daire.mcnamara@microchip.com |
|---|---|
| Headers | show |
| Series | i2c: microchip: Add driver for PolarFire SoC | expand |
On Wed, 12 May 2021 12:20:23 +0100, daire.mcnamara@microchip.com wrote: > From: Daire McNamara <daire.mcnamara@microchip.com> > > Add device tree bindings for the Microchip PolarFire I2C controller > > Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com> > --- > .../bindings/i2c/microchip,mpfs-i2c.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/microchip,mpfs-i2c.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/i2c/microchip,mpfs-i2c.example.dts:19:18: fatal error: dt-bindings/clock/microchip,mpfs-clock.h: No such file or directory 19 | #include <dt-bindings/clock/microchip,mpfs-clock.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/i2c/microchip,mpfs-i2c.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1416: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1477553 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Rob, > Documentation/devicetree/bindings/i2c/microchip,mpfs-i2c.example.dts:19:18: fatal error: dt-bindings/clock/microchip,mpfs-clock.h: No such file or directory > 19 | #include <dt-bindings/clock/microchip,mpfs-clock.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. I'd think this is only because the file has not hit -next yet? Would you be so kind and review the bindings nonetheless? Thank you and kind regards, Wolfram
From: Daire McNamara <daire.mcnamara@microchip.com> This patchset adds support for the Microchip PolarFire SoC I2C hardware block. Daire McNamara (2): dt-bindings: i2c: microchip: Add Microchip PolarFire host binding i2c: microchip: Add driver for Microchip PolarFire SoC .../bindings/i2c/microchip,mpfs-i2c.yaml | 74 +++ drivers/i2c/busses/Kconfig | 6 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-microchip.c | 519 ++++++++++++++++++ 4 files changed, 600 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/microchip,mpfs-i2c.yaml create mode 100755 drivers/i2c/busses/i2c-microchip.c base-commit: acd3d28594536e9096c1ea76c5867d8a68babef6 prerequisite-patch-id: 6f7f70120adfa8e938b97517f0c664e43e8745a0 prerequisite-patch-id: 4ea37008d23838aa2e0658811fe15462f6cdbd87 prerequisite-patch-id: 378c9d7495e56454b7bffbdbc430185dc4e36b90 prerequisite-patch-id: b547bbdf0a800c652cdd1a542b8ce725dfd6fcc9 prerequisite-patch-id: 26afc006e51cf743902bf609b537e1558e70f69c prerequisite-patch-id: 55e615f1af62373acc71366ceb4c27fbcecec60d prerequisite-patch-id: 6bda20a1c98622e33f3bf0126ae696716c963e4b