| Message ID | 20210201175138.8986-1-mail@richard-neumann.de |
|---|---|
| Headers | show |
| Series | i2c: i2c-amd-mp2: Clean up driver | expand |
On Mon, Feb 01, 2021 at 06:51:37PM +0100, Richard Neumann wrote: > Use pci_{info,warn,err,dbg} functions of the kernel's PCI API. > Remove unnecessary ndev_pdev(), ndev_name() and ndev_dev() macros. > While at it, remove useless __func__ from logging. > > Signed-off-by: Richard Neumann <mail@richard-neumann.de> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> I haven't given you the tag for this patch, but this time it's okay, no need to resend.
On Mon, Feb 01, 2021 at 06:51:37PM +0100, Richard Neumann wrote: > Use pci_{info,warn,err,dbg} functions of the kernel's PCI API. > Remove unnecessary ndev_pdev(), ndev_name() and ndev_dev() macros. > While at it, remove useless __func__ from logging. > > Signed-off-by: Richard Neumann <mail@richard-neumann.de> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> $subject looked wrong to me so I changed it to "convert to PCI logging functions". Applied to for-next, thanks!
Clean up i2c-amd-mp2-{pci,plat} drivers: * Use pci_* logging functions provided by the kernel's PCI API. * Remove unused macros. * Remove useless __func__ from logging. Changes since v1: * Remove useless __func__ from logging. * Assign pci_dev to local variable where applicable. Changes since v2: * Remove duplicate local pointer to pci_dev. Richard Neumann (2): i2c: i2c-amd-mp2: Remove NIH logging functions i2c: i2c-amd-mp2: Remove unused macro drivers/i2c/busses/i2c-amd-mp2-pci.c | 55 +++++++++++---------------- drivers/i2c/busses/i2c-amd-mp2-plat.c | 3 +- drivers/i2c/busses/i2c-amd-mp2.h | 6 --- 3 files changed, 24 insertions(+), 40 deletions(-)