mbox series

[RESEND,v3,0/2] i2c: i2c-mux-gpio: Enable this driver in ACPI land

Message ID 20201118234025.376412-1-evgreen@chromium.org
Headers show
Series i2c: i2c-mux-gpio: Enable this driver in ACPI land | expand

Message

Evan Green Nov. 18, 2020, 11:40 p.m. UTC 
The i2c-mux-gpio driver is a handy driver to have in your bag of tricks,
but it currently only works with DT-based firmware. Enable this driver
on ACPI platforms as well.

The first patch is a little dinky. Peter, if it turns out you'd rather
just take this all as a single patch, feel free to squash the first
patch into the second. Or I can resend a squashed patch if needed.

Changes in v3:
 - Introduced minor &pdev->dev to dev refactor (Peter)
 - Update commit message again (Peter)
 - Added missing \n (Peter)
 - adr64 overflow check (Peter)
 - Don't initialize child (Peter)
 - Limit scope of dev_handle (Peter)

Changes in v2:
 - Make it compile properly when !CONFIG_ACPI (Randy)
 - Update commit message regarding i2c-parent (Peter)

Evan Green (2):
  i2c: i2c-mux-gpio: Factor out pdev->dev in _probe_dt()
  i2c: i2c-mux-gpio: Enable this driver in ACPI land

 drivers/i2c/muxes/i2c-mux-gpio.c | 112 ++++++++++++++++++++++---------
 1 file changed, 82 insertions(+), 30 deletions(-)

Comments

Peter Rosin Jan. 15, 2021, 9:30 a.m. UTC | #1 
On 2020-11-19 00:40, Evan Green wrote:
> Factor out &pdev->dev into a local variable in preparation for

> the ACPI enablement of this function, which will utilize the variable

> more.

> 

> Signed-off-by: Evan Green <evgreen@chromium.org>

> ---

> 

> Changes in v3:

>  - Introduced minor &pdev->dev to dev refactor (Peter)

> 

>  drivers/i2c/muxes/i2c-mux-gpio.c | 5 +++--

>  1 file changed, 3 insertions(+), 2 deletions(-)


Acked-by: Peter Rosin <peda@axentia.se>


(this patch doesn't make much sense without 2/2)

Cheers,
Peter
Wolfram Sang Jan. 17, 2021, 11:53 a.m. UTC | #2 
On Wed, Nov 18, 2020 at 03:40:24PM -0800, Evan Green wrote:
> Factor out &pdev->dev into a local variable in preparation for

> the ACPI enablement of this function, which will utilize the variable

> more.

> 

> Signed-off-by: Evan Green <evgreen@chromium.org>


Applied to for-next, thanks!