From patchwork Wed Nov 25 10:27:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 57290 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp2649346lbb; Wed, 25 Nov 2015 02:27:52 -0800 (PST) X-Received: by 10.98.1.213 with SMTP id 204mr30477925pfb.128.1448447272353; Wed, 25 Nov 2015 02:27:52 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s74si33463404pfs.7.2015.11.25.02.27.52; Wed, 25 Nov 2015 02:27:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro-org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395AbbKYK1u (ORCPT + 4 others); Wed, 25 Nov 2015 05:27:50 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:33772 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752248AbbKYK1r (ORCPT ); Wed, 25 Nov 2015 05:27:47 -0500 Received: by oixx65 with SMTP id x65so26555740oix.0 for ; Wed, 25 Nov 2015 02:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=H+//gW5h2Hb2Vz4B6Oz6A+BHsbe24TGdG5w80L2iu1A=; b=jXLpqgxahJaK+N5van/zuSZgnyXsyF7y5CzmFKV1/EVJXPfF1fWDbLrzcgx/nq6G7S FijvI/fkUQZN9TAbAOGqwQtNUVsiRMx/wZYgJteGIJT0cTV9kk0E97B4RAVnzx7Fc+QZ UIxbHT8P0Rf56w6jHePk6m27j949NAd/qRQfVnGoBTH5RZcStf/tIupxrfHxYYgG2cvN YKXEtgYQ6bAWv/pOHm1e8MGOqsTxK2fO9JfRMswUA2dwIKXrxsNaMEVxRptZM3y+3FrS nrygUl+AGl3f/+iw1ms8McPpbiEdF4hB399gdGpUEgsMtiIDE0n6PdugUT877PQvwHmW VJiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc :content-type; bh=H+//gW5h2Hb2Vz4B6Oz6A+BHsbe24TGdG5w80L2iu1A=; b=PeB7Ogy9HqBcCI5eO4GVSheLafBb5LmHxO4t+7svy3yB9izwqKXAGxBoCa45Hlkhrl c4spMEgeupgLBnzD4QcQBqV3S13vIWfTdhHbBVjPBmBgWSuG/Vu79Aovbn6+AgrN6NWc Lmh0tYpg+Axkqi0RNQttbIAxfPDF3ArPKDsaguipHOzKHQhN6sg30EOPcS3s5JPl5tKU QTwaxLVl8E4PW4wk33WkYQ26GEn/4MUbk7QOepO+yHfYcbdIsrG0mA9BqFETMocTnv/A iCAkrIJ/NqykjEASpBTyj9ChB0u1jzKPHTrhZFaYdSXq/6JalqPRFLM/TrWF+Nw6NBsV 2zlA== X-Gm-Message-State: ALoCoQldrIQ8SazDYIU+gZ61dK0J5i9QK2QAF+RDtYAh3CkMoyR5XHoybKGxaNRlTBl8drS38mQq MIME-Version: 1.0 X-Received: by 10.202.71.132 with SMTP id u126mr23197407oia.113.1448447267043; Wed, 25 Nov 2015 02:27:47 -0800 (PST) Received: by 10.182.32.70 with HTTP; Wed, 25 Nov 2015 02:27:46 -0800 (PST) Date: Wed, 25 Nov 2015 11:27:46 +0100 Message-ID: Subject: Strange message from Kirkwood pinctrl driver From: Linus Walleij To: "linux-gpio@vger.kernel.org" , Sebastian Hesselbarth , "linux-arm-kernel@lists.infradead.org" Cc: Simon Guinot , Thomas Petazzoni , Jason Cooper , Andrew Lunn , Gregory Clement Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Sebastian, trying to use the Kirkwood pinctrl driver with compatible = "marvell,88f6192-pinctrl"; on a Pogoplug series 4 yields the following message when instantiating the driver: kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 36 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 37 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 38 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 39 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 40 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 41 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 42 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 43 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 44 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 45 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 46 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 47 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 48 kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 49 kirkwood-pinctrl f1010000.pin-controller: registered pinctrl driver It looks harmless but seems like a bug and make me uncertain. The following naive patch fixes it: What is the proper way to fix this? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c index 0f07dc554a1d..6c7c2c8819b8 100644 --- a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c +++ b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c @@ -411,7 +411,7 @@ static struct mvebu_pinctrl_soc_info mv88f6190_info = { .controls = mv88f619x_mpp_controls, .ncontrols = ARRAY_SIZE(mv88f619x_mpp_controls), .modes = mv88f6xxx_mpp_modes, - .nmodes = ARRAY_SIZE(mv88f6xxx_mpp_modes), + .nmodes = ARRAY_SIZE(mv88f6xxx_mpp_modes) - 14, .gpioranges = mv88f619x_gpio_ranges, .ngpioranges = ARRAY_SIZE(mv88f619x_gpio_ranges), }; @@ -421,7 +421,7 @@ static struct mvebu_pinctrl_soc_info mv88f6192_info = { .controls = mv88f619x_mpp_controls, .ncontrols = ARRAY_SIZE(mv88f619x_mpp_controls), .modes = mv88f6xxx_mpp_modes, - .nmodes = ARRAY_SIZE(mv88f6xxx_mpp_modes), + .nmodes = ARRAY_SIZE(mv88f6xxx_mpp_modes) - 14, .gpioranges = mv88f619x_gpio_ranges, .ngpioranges = ARRAY_SIZE(mv88f619x_gpio_ranges), };