From patchwork Fri Oct 14 10:47:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 615141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63587C433FE for ; Fri, 14 Oct 2022 10:47:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbiJNKr5 (ORCPT ); Fri, 14 Oct 2022 06:47:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbiJNKr4 (ORCPT ); Fri, 14 Oct 2022 06:47:56 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF64426F6 for ; Fri, 14 Oct 2022 03:47:55 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id t12-20020a17090a3b4c00b0020b04251529so4425035pjf.5 for ; Fri, 14 Oct 2022 03:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5qGaiEFLaBnpGGmWZydBFvA7FCLNISeMhhUxsl1cBpk=; b=fFPo1MtW+NWvL31KHsHgwoGmezzRdq7gtfXgjuKWQvPgo9LOebCptEZn8Dke7oxkTK WLZOSTqn0zqp2pa3ih+99CODM70lfNwTVsnxmTuCwyheuRi9CCPAKJCEor7zLayJ17H9 s636wK6Is8vwZZD0ux19HPUd86Ob69P6rp5zsmqqMchpfh/bA8/+Nhw/aRU06MMY0rv5 GK9mkj+5cePo7c+7q3Cpth9rzKKGU/KO0Joqs0Ur0xAeE1WjYdhV1lMPd++8o9xr52l4 URGKate2pHYdg/mAUDWdWMw7+k0Z8Ml1PZ79quID/b3BMqTaHDd/v6F5RrPaXw768Lq5 kmzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5qGaiEFLaBnpGGmWZydBFvA7FCLNISeMhhUxsl1cBpk=; b=lpQW4cEJfz64vJNtZDL5oafekFgOpiqMeqpeUYZEGSoImAHojlUVlHIv3/BLuPAcDN AIKqmqg9/WBbIr3Xjf0KwWfEe7AN5spCRru1yUgwA3pSxyjQIVNgBakrz1BAtnwGqLaQ 0UItBvxpZU2CmNlnKlka0iCKSZd91+C2mCIJd2usKNwqVBGVLEmzr83ldDkeUrUBJAtU H/y6k6lW9D8fGDTEB+a39wxyX4hAYk5Jzqmxhg3kPMpHv4HRBxgbexDqgIz/sG/kHts5 syOplN/cSeukrb82AOX5HQCoze0g9GtHMotiSr9vzm3GpD7wC00wFkpZTCk3g/UXxHyO LVOQ== X-Gm-Message-State: ACrzQf213m+yABt4TlJ0yTzSJmeZk4qJT3CwEIUTDI9QfEnAcQE6iF2d SGihadeLQlOtLZ3IKI7/SM2zqw== X-Google-Smtp-Source: AMsMyM6aWKh0U8+bGw9RjAiwl0uqJ1Ve32B6sajjOKAAPX2ldrHx9JkfTvSR9cerE+A9X/CoC0OZ/Q== X-Received: by 2002:a17:90a:2bcb:b0:20a:ea55:32ef with SMTP id n11-20020a17090a2bcb00b0020aea5532efmr16618167pje.59.1665744475613; Fri, 14 Oct 2022 03:47:55 -0700 (PDT) Received: from localhost ([122.172.86.128]) by smtp.gmail.com with ESMTPSA id o125-20020a62cd83000000b00561c179e17dsm1375786pfg.76.2022.10.14.03.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 03:47:54 -0700 (PDT) From: Viresh Kumar To: Linus Walleij , Bartosz Golaszewski Cc: Viresh Kumar , Vincent Guittot , linux-gpio@vger.kernel.org, Kent Gibson , Miguel Ojeda , Wedson Almeida Filho , =?utf-8?q?Alex_Benn=C3=A9e?= , stratos-dev@op-lists.linaro.org, Gerard Ryan Subject: [PATCH V7 8/8] libgpiod: Integrate building of rust bindings with make Date: Fri, 14 Oct 2022 16:17:25 +0530 Message-Id: <3e7fb99173856a3995360fc3fad51220c4b4e90e.1665744170.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Lets make build rust bindings as well. Signed-off-by: Viresh Kumar --- README | 8 +++++--- TODO | 8 -------- bindings/Makefile.am | 6 ++++++ bindings/rust/Makefile.am | 18 ++++++++++++++++++ configure.ac | 16 ++++++++++++++++ 5 files changed, 45 insertions(+), 11 deletions(-) create mode 100644 bindings/rust/Makefile.am diff --git a/README b/README index 814a0f161fd2..68b5d69f9b66 100644 --- a/README +++ b/README @@ -119,9 +119,9 @@ TOOLS BINDINGS -------- -High-level, object-oriented bindings for C++ and python3 are provided. They -can be enabled by passing --enable-bindings-cxx and --enable-bindings-python -arguments respectively to configure. +High-level, object-oriented bindings for C++, python3 and Rust are provided. +They can be enabled by passing --enable-bindings-cxx, --enable-bindings-python +and --enable-bindings-rust arguments respectively to configure. C++ bindings require C++11 support and autoconf-archive collection if building from git. @@ -132,6 +132,8 @@ the PYTHON_CPPFLAGS and PYTHON_LIBS variables in order to point the build system to the correct locations. During native builds, the configure script can auto-detect the location of the development files. +Rust bindings require cargo support. + TESTING ------- diff --git a/TODO b/TODO index 8bb4d8f3ad56..cf4fd7b4a962 100644 --- a/TODO +++ b/TODO @@ -28,14 +28,6 @@ and is partially functional. ---------- -* implement rust bindings - -With Rust gaining popularity as a low-level system's language and the -possibility of it making its way into the linux kernel, it's probably time to -provide Rust bindings to libgpiod as part of the project. - ----------- - * implement a simple daemon for controlling GPIOs in C together with a client program diff --git a/bindings/Makefile.am b/bindings/Makefile.am index 8f8c762f254f..004ae23dbc58 100644 --- a/bindings/Makefile.am +++ b/bindings/Makefile.am @@ -14,3 +14,9 @@ if WITH_BINDINGS_PYTHON SUBDIRS += python endif + +if WITH_BINDINGS_RUST + +SUBDIRS += rust + +endif diff --git a/bindings/rust/Makefile.am b/bindings/rust/Makefile.am new file mode 100644 index 000000000000..79a52bc691ae --- /dev/null +++ b/bindings/rust/Makefile.am @@ -0,0 +1,18 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# SPDX-FileCopyrightText: 2022 Viresh Kumar + +command = cargo build --release --lib + +if WITH_TESTS +command += --tests +endif + +if WITH_EXAMPLES +command += --examples +endif + +all: + $(command) + +clean: + cargo clean diff --git a/configure.ac b/configure.ac index 6ac1d8ed8a40..37cfdb3644f7 100644 --- a/configure.ac +++ b/configure.ac @@ -212,6 +212,21 @@ then [AC_SUBST(PYTHON_LIBS, [`$PYTHON-config --libs`])]) fi +AC_ARG_ENABLE([bindings-rust], + [AS_HELP_STRING([--enable-bindings-rust],[enable rust bindings [default=no]])], + [if test "x$enableval" = xyes; then with_bindings_rust=true; fi], + [with_bindings_rust=false]) +AM_CONDITIONAL([WITH_BINDINGS_RUST], [test "x$with_bindings_rust" = xtrue]) + +if test "x$with_bindings_rust" = xtrue +then + AC_CHECK_PROG([has_cargo], [cargo], [true], [false]) + if test "x$has_cargo" = xfalse + then + AC_MSG_ERROR([cargo not found - needed for rust bindings]) + fi +fi + AC_CHECK_PROG([has_doxygen], [doxygen], [true], [false]) AM_CONDITIONAL([HAS_DOXYGEN], [test "x$has_doxygen" = xtrue]) if test "x$has_doxygen" = xfalse @@ -246,6 +261,7 @@ AC_CONFIG_FILES([Makefile bindings/python/Makefile bindings/python/examples/Makefile bindings/python/tests/Makefile + bindings/rust/Makefile man/Makefile]) AC_OUTPUT