diff mbox series

[2/2] dt-bindings: gpio: fairchild,74hc595: use a fallback for Semi MC74HC595A

Message ID 20250110130025.55004-3-brgl@bgdev.pl
State New
Headers show
Series gpio: 74x164: use a compatible fallback and don't extend the driver | expand

Commit Message

Bartosz Golaszewski Jan. 10, 2025, 1 p.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This model is 1:1 compatible with fairchild,74hc595 so use the latter as
a fallback instead of adding a new stand-alone compatible.

Fixes: 0ba6cec7acbb ("dt-bindings: gpio: fairchild,74hc595: Add On Semi MC74HC595A compat")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 .../devicetree/bindings/gpio/fairchild,74hc595.yaml    | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comments

Krzysztof Kozlowski Jan. 11, 2025, 10:50 a.m. UTC | #1 
On Fri, Jan 10, 2025 at 02:00:25PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> This model is 1:1 compatible with fairchild,74hc595 so use the latter as
> a fallback instead of adding a new stand-alone compatible.
> 
> Fixes: 0ba6cec7acbb ("dt-bindings: gpio: fairchild,74hc595: Add On Semi MC74HC595A compat")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  .../devicetree/bindings/gpio/fairchild,74hc595.yaml    | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> index a209c5b4f6e0..da462dddb140 100644
> --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> @@ -28,10 +28,12 @@ maintainers:
>  
>  properties:
>    compatible:
> -    enum:
> -      - fairchild,74hc595
> -      - nxp,74lvc594
> -      - onnn,74hc595a
> +    oneOf:
> +      - const: fairchild,74hc595
> +      - const: nxp,74lvc594

Keep enum for these two, preferred pattern.

> +      - items:
> +          - const: onnn,74hc595a
> +          - const: fairchild,74hc595

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
index a209c5b4f6e0..da462dddb140 100644
--- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
+++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
@@ -28,10 +28,12 @@  maintainers:
 
 properties:
   compatible:
-    enum:
-      - fairchild,74hc595
-      - nxp,74lvc594
-      - onnn,74hc595a
+    oneOf:
+      - const: fairchild,74hc595
+      - const: nxp,74lvc594
+      - items:
+          - const: onnn,74hc595a
+          - const: fairchild,74hc595
 
   reg:
     maxItems: 1