| Message ID | 20240828-dt-bindings-gpio-hog-v1-2-63b83e47d804@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: gpio/pinctrl: add missing type to GPIO hogs | expand |
On Wed, Aug 28, 2024 at 11:36 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > GPIO hog nodes should define type, otherwise "dummy-hog" boolean > properties would be allowed. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> I suppose it's best of Bartosz applies this to the GPIO tree with the rest of the series? Yours, Linus Walleij
On Sat, Aug 31, 2024 at 12:32 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Aug 28, 2024 at 11:36 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > > GPIO hog nodes should define type, otherwise "dummy-hog" boolean > > properties would be allowed. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > I suppose it's best of Bartosz applies this to the GPIO tree with > the rest of the series? > > Yours, > Linus Walleij Ah, I picked up the GPIO changes separately. No problem, I'll pick this one up as well. Bart
On Mon, Sep 2, 2024 at 11:50 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > On Sat, Aug 31, 2024 at 12:32 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > On Wed, Aug 28, 2024 at 11:36 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > > > > > GPIO hog nodes should define type, otherwise "dummy-hog" boolean > > > properties would be allowed. > > > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > > > I suppose it's best of Bartosz applies this to the GPIO tree with > > the rest of the series? > > > > Yours, > > Linus Walleij > > Ah, I picked up the GPIO changes separately. No problem, I'll pick > this one up as well. > > Bart Nope, I cannot, this doesn't apply to the GPIO tree. Bart
On 02/09/2024 11:51, Bartosz Golaszewski wrote: > On Mon, Sep 2, 2024 at 11:50 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: >> >> On Sat, Aug 31, 2024 at 12:32 AM Linus Walleij <linus.walleij@linaro.org> wrote: >>> >>> On Wed, Aug 28, 2024 at 11:36 AM Krzysztof Kozlowski >>> <krzysztof.kozlowski@linaro.org> wrote: >>> >>>> GPIO hog nodes should define type, otherwise "dummy-hog" boolean >>>> properties would be allowed. >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >>> >>> I suppose it's best of Bartosz applies this to the GPIO tree with >>> the rest of the series? >>> >>> Yours, >>> Linus Walleij >> >> Ah, I picked up the GPIO changes separately. No problem, I'll pick >> this one up as well. >> >> Bart > > Nope, I cannot, this doesn't apply to the GPIO tree. Hm, probably there is something in pinctrl tree. @Linus, can you grab pinctrl bits? Best regards, Krzysztof
On Mon, Sep 2, 2024 at 12:02 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > >>> I suppose it's best of Bartosz applies this to the GPIO tree with > >>> the rest of the series? > >>> > >>> Yours, > >>> Linus Walleij > >> > >> Ah, I picked up the GPIO changes separately. No problem, I'll pick > >> this one up as well. > >> > >> Bart > > > > Nope, I cannot, this doesn't apply to the GPIO tree. > > Hm, probably there is something in pinctrl tree. > > @Linus, can you grab pinctrl bits? OK I applied this patch 2/3 to the pinctrl tree! Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.yaml index ebf74e48ec5b..cc5de9f77680 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.yaml @@ -37,6 +37,7 @@ patternProperties: additionalProperties: false "-hog(-[0-9]+)?$": + type: object required: - gpio-hog diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml index 2784d32fdde2..c1b799167d81 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml @@ -425,6 +425,7 @@ patternProperties: additionalProperties: false "-hog(-[0-9]+)?$": + type: object required: - gpio-hog diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml index dfe5616b9b85..0f331844608c 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml @@ -43,6 +43,7 @@ patternProperties: additionalProperties: false "-hog(-[0-9]+)?$": + type: object required: - gpio-hog
GPIO hog nodes should define type, otherwise "dummy-hog" boolean properties would be allowed. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.yaml | 1 + Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 1 + Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml | 1 + 3 files changed, 3 insertions(+)