[libgpiod,6/8] tools: tests: check exit code directly

Message ID	20240531134512.443850-7-warthog618@gmail.com
State	Superseded
Headers	show Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2EF2159568 for <linux-gpio@vger.kernel.org>; Fri, 31 May 2024 13:46:36 +0000 (UTC) From: Kent Gibson <warthog618@gmail.com> To: linux-gpio@vger.kernel.org, brgl@bgdev.pl Cc: Kent Gibson <warthog618@gmail.com> Subject: [libgpiod][PATCH 6/8] tools: tests: check exit code directly Date: Fri, 31 May 2024 21:45:10 +0800 Message-Id: <20240531134512.443850-7-warthog618@gmail.com> In-Reply-To: <20240531134512.443850-1-warthog618@gmail.com> References: <20240531134512.443850-1-warthog618@gmail.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	tools: tests: fix shellcheck warnings \| expand [libgpiod,0/8] tools: tests: fix shellcheck warnings [libgpiod,1/8] tools: tests: don't mix string and array [libgpiod,2/8] tools: tests: don't declare and assign separately [libgpiod,3/8] tools: tests: fix unused variables [libgpiod,4/8] tools: tests: use read -r to avoid mangling backslashes [libgpiod,5/8] tools: tests: don't use variables in printf format string [libgpiod,6/8] tools: tests: check exit code directly [libgpiod,7/8] tools: tests: shellcheck don't follow sourced file [libgpiod,8/8] tools: tests: avoid splitting and globbing

Message ID

20240531134512.443850-7-warthog618@gmail.com

State

Superseded

Headers

From: Kent Gibson <warthog618@gmail.com>
To: linux-gpio@vger.kernel.org,
	brgl@bgdev.pl
Cc: Kent Gibson <warthog618@gmail.com>
Subject: [libgpiod][PATCH 6/8] tools: tests: check exit code directly
Date: Fri, 31 May 2024 21:45:10 +0800
Message-Id: <20240531134512.443850-7-warthog618@gmail.com>
In-Reply-To: <20240531134512.443850-1-warthog618@gmail.com>
References: <20240531134512.443850-1-warthog618@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

tools: tests: fix shellcheck warnings | expand

Commit Message

Kent Gibson May 31, 2024, 1:45 p.m. UTC

Fix shellcheck SC2181[1] - check exit code directly.

Signed-off-by: Kent Gibson <warthog618@gmail.com>

[1] https://www.shellcheck.net/wiki/SC2181
---
 tools/gpio-tools-test.bash | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/gpio-tools-test.bash b/tools/gpio-tools-test.bash
index d9930f1..83b05ec 100755
--- a/tools/gpio-tools-test.bash
+++ b/tools/gpio-tools-test.bash
@@ -3069,8 +3069,7 @@  check_kernel() {
 check_prog() {
 	local PROG=$1
 
-	which "$PROG" > /dev/null
-	if [ "$?" -ne "0" ]
+	if ! which "$PROG" > /dev/null
 	then
 		die "$PROG not found - needed to run the tests"
 	fi

[libgpiod,6/8] tools: tests: check exit code directly

Commit Message

Patch