From patchwork Tue Jul 18 22:30:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 704181 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5693FC001DE for ; Tue, 18 Jul 2023 22:30:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231356AbjGRWa5 (ORCPT ); Tue, 18 Jul 2023 18:30:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231199AbjGRWa4 (ORCPT ); Tue, 18 Jul 2023 18:30:56 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCE711992; Tue, 18 Jul 2023 15:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689719455; x=1721255455; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gci7SrqTXmudDsrVtfyn4d9ShON4LMyRPPd6NvIPQZQ=; b=QqXaeWueu/D8qQYKOVbebToCWNCqh41Qd9Yr19sAtl+ejMVel3BQId2E cGYdpk/oGoNdnkprXFzvSqjaYGgUF2bcJ08X5pJ2IxBVkidLr5mP4fYG+ rrOkxc8weye8zt5HcBd0sr2dJS9U/gaY3ISYiRsmvUmFoTCKqExzVRxtf 3oKP2vOUhXESex7DWCnhNlrUrudHQcYoIK5ht8AP3yVCJsdZWA8znBxiV c/rw02U4cnUBXlD/FWkbuisFyXj7miQ/iS4onaWVeibWABMzYxsgQYeAA q53wUk1hfccJmnH+sKRtglQPYO+3uO7XEGEU56IJjqyoeW5rhsC8YADNB w==; X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="366369827" X-IronPort-AV: E=Sophos;i="6.01,215,1684825200"; d="scan'208";a="366369827" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 15:30:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="793791445" X-IronPort-AV: E=Sophos;i="6.01,215,1684825200"; d="scan'208";a="793791445" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 18 Jul 2023 15:30:52 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id F121412C; Wed, 19 Jul 2023 01:30:58 +0300 (EEST) From: Andy Shevchenko To: Bartosz Golaszewski , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Ray Jui , Broadcom internal kernel review list , Florian Fainelli , Scott Branden , Andrei Coardos , Alexandru Ardelean Subject: [PATCH v3 2/3] gpio: bcm-kona: remove unneeded platform_set_drvdata() call Date: Wed, 19 Jul 2023 01:30:54 +0300 Message-Id: <20230718223055.2809-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230718223055.2809-1-andriy.shevchenko@linux.intel.com> References: <20230718223055.2809-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Andrei Coardos The platform_set_drvdata() call was never used, ever since the driver was originally added. It looks like this copy+paste left-over. Possibly the author copied from a driver that had this line, but also had a remove hook. Reviewed-by: Alexandru Ardelean Signed-off-by: Andrei Coardos Signed-off-by: Andy Shevchenko --- v2: no changes v3: no changes drivers/gpio/gpio-bcm-kona.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c index c977144eff10..f67c0f76a196 100644 --- a/drivers/gpio/gpio-bcm-kona.c +++ b/drivers/gpio/gpio-bcm-kona.c @@ -592,7 +592,6 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev) return -ENOMEM; kona_gpio->pdev = pdev; - platform_set_drvdata(pdev, kona_gpio); chip->parent = dev; chip->ngpio = kona_gpio->num_bank * GPIO_PER_BANK;