| Message ID | 20230609082539.24311-2-raag.jadav@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Minor improvements for Intel pinctrl | expand |
> On Fri, Jun 09, 2023 at 01:55:36PM +0530, Raag Jadav wrote: > > Utilize a temporary variable for common shift operation inside > > ->set_mux() hook and improve readability. > > Seems the bloat-o-meter statistics is missing here. I changed the commit message as pointed out by Mika in v1. Do I change it back?
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index c7a71c49df0a..e8adf2580321 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -411,18 +411,19 @@ static int intel_pinmux_set_mux(struct pinctrl_dev *pctldev, /* Now enable the mux setting for each pin in the group */ for (i = 0; i < grp->grp.npins; i++) { void __iomem *padcfg0; - u32 value; + u32 value, pmode; padcfg0 = intel_get_padcfg(pctrl, grp->grp.pins[i], PADCFG0); - value = readl(padcfg0); + value = readl(padcfg0); value &= ~PADCFG0_PMODE_MASK; if (grp->modes) - value |= grp->modes[i] << PADCFG0_PMODE_SHIFT; + pmode = grp->modes[i]; else - value |= grp->mode << PADCFG0_PMODE_SHIFT; + pmode = grp->mode; + value |= pmode << PADCFG0_PMODE_SHIFT; writel(value, padcfg0); }
Utilize a temporary variable for common shift operation inside ->set_mux() hook and improve readability. Signed-off-by: Raag Jadav <raag.jadav@intel.com> --- drivers/pinctrl/intel/pinctrl-intel.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)