From patchwork Tue Apr 4 00:45:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 670639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E60C76188 for ; Tue, 4 Apr 2023 00:45:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231546AbjDDApz (ORCPT ); Mon, 3 Apr 2023 20:45:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbjDDApy (ORCPT ); Mon, 3 Apr 2023 20:45:54 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A1C41705 for ; Mon, 3 Apr 2023 17:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680569106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=aYUqj0WEO/+t8WQOwTQ6jFSvWovdgaLHCs5zUkIn40o=; b=Esbh4SH4RN3FjGT5/759VFWRUWLYP9zSgJQBBjgICiEzurgrYVEHnf20vHBV/29Vqw3iYI Kl5IFpl+Yjkn5zvWNOvV2+5RoSW5mDlZj2MeG1FdjKEiExf27FvrpcT7IXBgw+1pL+3FQE x/ge1yJZTiFrliRkCgATBAMGIl2vzo0= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-114-W1vCZqANNUyzDBrzjjmocQ-1; Mon, 03 Apr 2023 20:45:05 -0400 X-MC-Unique: W1vCZqANNUyzDBrzjjmocQ-1 Received: by mail-qt1-f198.google.com with SMTP id r4-20020ac867c4000000b003bfefb6dd58so21116321qtp.2 for ; Mon, 03 Apr 2023 17:45:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680569104; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aYUqj0WEO/+t8WQOwTQ6jFSvWovdgaLHCs5zUkIn40o=; b=l35KVoxd3XStg0JMs3Mjv7PKHCFbCmkCoCV0/3kNoFfMLC5G0N00dG6Uaj/OtaIOr4 17fJBKfIxAD/aF0li4o/w7Omk41G6LJ1bs9Lc0JWbEOvqonUwoLXCKZSsr9YtGA6qZ85 ey0OU6iVO71jAdAYN8gJnIV9CultpWKp6WR8OgvfpPNLbpFfm/OcAsrF1y47ydMMrSUW 12N7H7ihc+gtUD/QdO4TLMcEQwx7GXls2bCfOvodYXf+/r1wzacz0jbax38eEEEDUVDZ 8nGqHotilOpw3c+xFyv3RU1OT0P49VQo2922R/miauv6ldIBBDoruM85LHc4nul551Ad EtSQ== X-Gm-Message-State: AAQBX9d58b3R/Yz1gVPlEYppbbgRi8fBrEYjChGfyZN8DVVSxrvnCuvo yQxDElLZgRk2XjYJBqmvvNcI1jUuGLEb/1DL1d3fUO9HsxLSGh9h3xT1ALzj1CIWWcMzLFynMjo pNjHWs5Nt5jshp9HEseEA4w== X-Received: by 2002:a05:622a:199f:b0:3bf:e4da:2367 with SMTP id u31-20020a05622a199f00b003bfe4da2367mr852178qtc.3.1680569104582; Mon, 03 Apr 2023 17:45:04 -0700 (PDT) X-Google-Smtp-Source: AKy350a9PFso1zg83MNenFNB+OtbEohAAKjW2hu0gf7aXs/D7CoTeb87qGRoa22fHVShZm85hSn5Uw== X-Received: by 2002:a05:622a:199f:b0:3bf:e4da:2367 with SMTP id u31-20020a05622a199f00b003bfe4da2367mr852160qtc.3.1680569104334; Mon, 03 Apr 2023 17:45:04 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id c7-20020ac84e07000000b003e3921077d9sm2898823qtw.38.2023.04.03.17.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 17:45:04 -0700 (PDT) From: Tom Rix To: linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static Date: Mon, 3 Apr 2023 20:45:01 -0400 Message-Id: <20230404004501.1913144-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org smatch reports drivers/pinctrl/pinctrl-mlxbf3.c:162:20: warning: symbol 'mlxbf3_pmx_funcs' was not declared. Should it be static? This variable is only used in one file so it should be static. Signed-off-by: Tom Rix --- drivers/pinctrl/pinctrl-mlxbf3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-mlxbf3.c b/drivers/pinctrl/pinctrl-mlxbf3.c index 3698f7bbd88d..d9944e6a0af9 100644 --- a/drivers/pinctrl/pinctrl-mlxbf3.c +++ b/drivers/pinctrl/pinctrl-mlxbf3.c @@ -159,7 +159,7 @@ static const struct pinctrl_ops mlxbf3_pinctrl_group_ops = { static const char * const mlxbf3_gpiofunc_group_names[] = { "swctrl" }; static const char * const mlxbf3_hwfunc_group_names[] = { "hwctrl" }; -struct pinfunction mlxbf3_pmx_funcs[] = { +static struct pinfunction mlxbf3_pmx_funcs[] = { PINCTRL_PINFUNCTION("hwfunc", mlxbf3_hwfunc_group_names, 1), PINCTRL_PINFUNCTION("gpiofunc", mlxbf3_gpiofunc_group_names, 1), };