From patchwork Mon Mar 6 19:55:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 659565 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20939C6FD1D for ; Mon, 6 Mar 2023 19:56:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbjCFT4S (ORCPT ); Mon, 6 Mar 2023 14:56:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230296AbjCFT4G (ORCPT ); Mon, 6 Mar 2023 14:56:06 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0DD96A047; Mon, 6 Mar 2023 11:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132546; x=1709668546; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uanU4QaIMKCYnVoRuj1LvDKlEUvFT3OubkE3zS0A1GQ=; b=AXwMHazS3PNUp6GHomch8z6bRBb+8YkVRL4dNibvlqQvY6O/rKh0N7x9 PzKn99ZUfoNuilMyc6Ou88SrOBZ6/JjF11wKpch3aWo5uaapJf4DydnJ/ 6pJBGEF+RjCbGm9nc7aGouBT6yELNYJRfsDzsTPPCkudh+JJTUibhAvfE 5++dzkSXBzjAODfo8bXP0DcqupESS4ahlUjpm4vK3GfxHnTHXbvMpDJHP XqE3PmZE7PmccWUtSDElFgBSH90XSCrXQnDYBd028758ITZUXoi6tIXO1 KRkFRC+H6WTu0GPoVtofYJBs1FMWmKkFLlb/uxSvMfcD8lZdyhQ03FCOv w==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333129019" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333129019" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185198" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185198" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id CE4C8609; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 13/16] gpio: wcove: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:53 +0200 Message-Id: <20230306195556.55475-14-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. While at, utilize specifier field for padding the strings where it's required. Signed-off-by: Andy Shevchenko Acked-by: Kuppuswamy Sathyanarayanan --- drivers/gpio/gpio-wcove.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c index c18b6b47384f..8d30fd04dede 100644 --- a/drivers/gpio/gpio-wcove.c +++ b/drivers/gpio/gpio-wcove.c @@ -15,6 +15,7 @@ #include #include #include +#include /* * Whiskey Cove PMIC has 13 physical GPIO pins divided into 3 banks: @@ -391,14 +392,14 @@ static void wcove_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) break; } - seq_printf(s, " gpio-%-2d %s %s %s %s ctlo=%2x,%s %s\n", - gpio, ctlo & CTLO_DIR_OUT ? "out" : "in ", - ctli & 0x1 ? "hi" : "lo", - ctli & CTLI_INTCNT_NE ? "fall" : " ", - ctli & CTLI_INTCNT_PE ? "rise" : " ", + seq_printf(s, " gpio-%-2d %-3.3s %-2.2s %-4.4s %-4.4s ctlo=%2x,%-6.6s %s\n", + gpio, str_out_in(ctlo & CTLO_DIR_OUT), + str_hi_lo(ctli & BIT(0)), + ctli & CTLI_INTCNT_NE ? "fall" : "", + ctli & CTLI_INTCNT_PE ? "rise" : "", ctlo, - irq_mask & mask ? "mask " : "unmask", - irq_status & mask ? "pending" : " "); + irq_mask & mask ? "mask" : "unmask", + irq_status & mask ? "pending" : ""); } }