[v1,09/17] pinctrl: cy8c95x0: Remove useless conditionals

Message ID	20220902182650.83098-9-andriy.shevchenko@linux.intel.com
State	Accepted
Commit	a416bfb7d595b423cf50af58f1ea9263f233fbd5
Headers	show Return-Path: <linux-gpio-owner@kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Linus Walleij <linus.walleij@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Patrick Rudolph <patrick.rudolph@9elements.com>, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 09/17] pinctrl: cy8c95x0: Remove useless conditionals Date: Fri, 2 Sep 2022 21:26:42 +0300 Message-Id: <20220902182650.83098-9-andriy.shevchenko@linux.intel.com> In-Reply-To: <20220902182650.83098-1-andriy.shevchenko@linux.intel.com> References: <20220902182650.83098-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	[v1,01/17] pinctrl: cy8c95x0: make irq_chip immutable \| expand [v1,01/17] pinctrl: cy8c95x0: make irq_chip immutable [v1,02/17] pinctrl: cy8c95x0: Allow IRQ chip core to handle numbering [v1,03/17] pinctrl: cy8c95x0: Allow most of the registers to be cached [v1,04/17] pinctrl: cy8c95x0: Fix return value in cy8c95x0_detect() [v1,05/17] pinctrl: cy8c95x0: Fix pin control name to enable more than one [v1,06/17] pinctrl: cy8c95x0: Drop unneeded npins assignment [v1,07/17] pinctrl: cy8c95x0: Enable GPIO range [v1,08/17] pinctrl: cy8c95x0: Remove device initialization [v1,09/17] pinctrl: cy8c95x0: Remove useless conditionals [v1,10/17] pinctrl: cy8c95x0: Remove custom ->set_config() [v1,11/17] pinctrl: cy8c95x0: Use 'default' in all switch-cases [v1,12/17] pinctrl: cy8c95x0: Implement ->pin_dbg_show() [v1,13/17] pinctrl: cy8c95x0: Make use of device properties [v1,14/17] pinctrl: cy8c95x0: support ACPI device found on Galileo Gen1 [v1,15/17] pinctrl: cy8c95x0: Override IRQ for one of the expanders on Galileo Gen 1 [v1,16/17] pinctrl: cy8c95x0: use bits.h macros for all masks [v1,17/17] pinctrl: cy8c95x0: Correct comment style

Message ID

20220902182650.83098-9-andriy.shevchenko@linux.intel.com

State

Accepted

Commit

a416bfb7d595b423cf50af58f1ea9263f233fbd5

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Patrick Rudolph <patrick.rudolph@9elements.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 09/17] pinctrl: cy8c95x0: Remove useless conditionals
Date: Fri,  2 Sep 2022 21:26:42 +0300
Message-Id: <20220902182650.83098-9-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20220902182650.83098-1-andriy.shevchenko@linux.intel.com>
References: <20220902182650.83098-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

[v1,01/17] pinctrl: cy8c95x0: make irq_chip immutable | expand

Commit Message

Andy Shevchenko Sept. 2, 2022, 6:26 p.m. UTC

The pin control framework checks pin boundaries before calling
the respective driver's callbacks. Hence no need to check for
pin boundaries, the respective conditionals won't be ever true.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/pinctrl-cy8c95x0.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c
index b09f9485e57d..97da22016cce 100644
--- a/drivers/pinctrl/pinctrl-cy8c95x0.c
+++ b/drivers/pinctrl/pinctrl-cy8c95x0.c
@@ -1029,14 +1029,6 @@  static int cy8c95x0_pinctrl_get_group_pins(struct pinctrl_dev *pctldev,
 					   const unsigned int **pins,
 					   unsigned int *num_pins)
 {
-	struct cy8c95x0_pinctrl *chip = pinctrl_dev_get_drvdata(pctldev);
-
-	if (group >= chip->tpin) {
-		*pins = NULL;
-		*num_pins = 0;
-		return 0;
-	}
-
 	*pins = &cy8c9560_pins[group].number;
 	*num_pins = 1;
 	return 0;
@@ -1104,9 +1096,6 @@  static int cy8c95x0_set_mux(struct pinctrl_dev *pctldev, unsigned int selector,
 {
 	struct cy8c95x0_pinctrl *chip = pinctrl_dev_get_drvdata(pctldev);
 
-	if (group >= chip->tpin)
-		return -EINVAL;
-
 	return cy8c95x0_pinmux_cfg(chip, selector, group);
 }
 
@@ -1133,9 +1122,6 @@  static int cy8c95x0_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
 	int ret = 0;
 	int i;
 
-	if (WARN_ON(pin >= chip->tpin))
-		return -EINVAL;
-
 	for (i = 0; i < num_configs; i++) {
 		ret = cy8c95x0_gpio_set_pincfg(chip, pin, configs[i]);
 		if (ret)

[v1,09/17] pinctrl: cy8c95x0: Remove useless conditionals

Commit Message

Patch