From patchwork Sat Jul 17 04:56:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Palmer X-Patchwork-Id: 479412 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D46C636CB for ; Sat, 17 Jul 2021 04:57:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B498E613F3 for ; Sat, 17 Jul 2021 04:57:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbhGQFAE (ORCPT ); Sat, 17 Jul 2021 01:00:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230392AbhGQE7q (ORCPT ); Sat, 17 Jul 2021 00:59:46 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71793C06175F for ; Fri, 16 Jul 2021 21:56:49 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id me13-20020a17090b17cdb0290173bac8b9c9so10021876pjb.3 for ; Fri, 16 Jul 2021 21:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fLDUaTCh3VK5lI9Kvmqz2LtxGRfdlTFuw6ZvgFybPpU=; b=qXnMdlmNRiHXn4gEatb5R2QPYD7u68zHYAV2t0+R9+sqFlxeNlUJKIIJOZCbzfUqS1 Uao6y0bjdBAJyQ17u19nr2Q/ZQUh6yGMYCFkZiE4l1PyrOHNOHPRNSxnjK7ikv1ocsoV jTjHfcpf1JBJbYeJFtQxH1ezS37Xz8XvfsRww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fLDUaTCh3VK5lI9Kvmqz2LtxGRfdlTFuw6ZvgFybPpU=; b=IfZ5HUpyqGAzFKQCY2L/SWd+NX5Yi43IBslqZgtB1hSnYSv5mtlvnby+8bYEAQjOK/ AnQ+jmV5CCB99RtKycQWn/YM21yfY0c+GwsZR8Z43E7Q7BG5RB1Lpjj24liAXUYxiWAn gGnRQpDGnpZRbh5PbwunUFu3ke8eN9Xpw7TW+M/k8zhuuUTosJwe3H2PiP53zY9Sw8w9 zi9EDAT2Qci1kC9hFI9CQIawAKj3qz3sbKtb+62svFbXM0E4tPcyVh1kZj0WJPPYW4mv 6GBvjFg3i/VoPE5tYRjFUr6ZhOZWrdVgwmNglcC7uLmMhyMdzh+prbRjFCCBC/nRZCvt CD+A== X-Gm-Message-State: AOAM530w0U8tO7BnpYlehU2O+AUeR/HPJGHzKGFp3ib6axwr+MNQ5Cw1 j2BfxYGEKwgsUmQrfJMoEztHpg== X-Google-Smtp-Source: ABdhPJxKYUOqP3DW/70zYd5fRMGwvv2i7eB31THLOGZFrdnFDAouv5BkHoNr7Q58CcKQKpTRtkZ0Pw== X-Received: by 2002:a17:90b:2382:: with SMTP id mr2mr18779595pjb.169.1626497809011; Fri, 16 Jul 2021 21:56:49 -0700 (PDT) Received: from shiro.work (p866038-ipngn200510sizuokaden.shizuoka.ocn.ne.jp. [180.9.60.38]) by smtp.googlemail.com with ESMTPSA id w2sm12522885pjf.2.2021.07.16.21.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 21:56:48 -0700 (PDT) From: Daniel Palmer To: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, robh@kernel.org, romain.perier@gmail.com, Daniel Palmer Subject: [PATCH 03/10] gpio: msc313: Code clean ups Date: Sat, 17 Jul 2021 13:56:20 +0900 Message-Id: <20210717045627.1739959-4-daniel@0x0f.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210717045627.1739959-1-daniel@0x0f.com> References: <20210717045627.1739959-1-daniel@0x0f.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org - Remove the unneeded assignment of ret before returning it. - Remove an unneeded blank line Signed-off-by: Daniel Palmer Reviewed-by: Linus Walleij --- drivers/gpio/gpio-msc313.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c index da31a5ff7a2b..a894bafbd4c3 100644 --- a/drivers/gpio/gpio-msc313.c +++ b/drivers/gpio/gpio-msc313.c @@ -344,7 +344,6 @@ static int msc313_gpio_probe(struct platform_device *pdev) struct irq_domain *parent_domain; struct device_node *parent_node; struct device *dev = &pdev->dev; - int ret; match_data = of_device_get_match_data(dev); if (!match_data) @@ -399,8 +398,7 @@ static int msc313_gpio_probe(struct platform_device *pdev) gpioirqchip->handler = handle_bad_irq; gpioirqchip->default_type = IRQ_TYPE_NONE; - ret = devm_gpiochip_add_data(dev, gpiochip, gpio); - return ret; + return devm_gpiochip_add_data(dev, gpiochip, gpio); } static int msc313_gpio_remove(struct platform_device *pdev) @@ -456,5 +454,4 @@ static struct platform_driver msc313_gpio_driver = { .probe = msc313_gpio_probe, .remove = msc313_gpio_remove, }; - builtin_platform_driver(msc313_gpio_driver);