diff mbox series

[v2,07/10] pinctrl: qcom/pinctrl-spmi-gpio: Add compatible for pmic-gpio on SA8155p-adp

Message ID 20210615074543.26700-8-bhupesh.sharma@linaro.org
State New
Headers show
Series [v2,01/10] dt-bindings: qcom: rpmh-regulator: Add compatible for SA8155p-adp board pmic | expand

Commit Message

Bhupesh Sharma June 15, 2021, 7:45 a.m. UTC
SA8155p-adp PMIC (PMM8155AU) exposes 10 GPIOs.

Add support for the same in the pinctrl driver.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Andy Gross <agross@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>

---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.31.1

Comments

Bjorn Andersson June 15, 2021, 9:07 p.m. UTC | #1
On Tue 15 Jun 02:45 CDT 2021, Bhupesh Sharma wrote:

> SA8155p-adp PMIC (PMM8155AU) exposes 10 GPIOs.

> 

> Add support for the same in the pinctrl driver.

> 

> Cc: Linus Walleij <linus.walleij@linaro.org>

> Cc: Liam Girdwood <lgirdwood@gmail.com>

> Cc: Mark Brown <broonie@kernel.org>

> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>

> Cc: Vinod Koul <vkoul@kernel.org>

> Cc: Rob Herring <robh+dt@kernel.org>

> Cc: Andy Gross <agross@kernel.org>


I don't think the Cc tags provides any value.

> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>

> ---

>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

> index 00870da0c94e..f886c683e2bd 100644

> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

> @@ -1127,6 +1127,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {

>  	{ .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },

>  	/* pm8150l has 12 GPIOs with holes on 7 */

>  	{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },

> +	{ .compatible = "qcom,pmm8155au-gpio", .data = (void *) 10 },


But we want to keep these sorted alphabetically.

Regards,
Bjorn

>  	{ .compatible = "qcom,pm8350-gpio", .data = (void *) 10 },

>  	{ .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },

>  	{ .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },

> -- 

> 2.31.1

>
diff mbox series

Patch

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 00870da0c94e..f886c683e2bd 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1127,6 +1127,7 @@  static const struct of_device_id pmic_gpio_of_match[] = {
 	{ .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
 	/* pm8150l has 12 GPIOs with holes on 7 */
 	{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pmm8155au-gpio", .data = (void *) 10 },
 	{ .compatible = "qcom,pm8350-gpio", .data = (void *) 10 },
 	{ .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
 	{ .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },