From patchwork Mon May 17 20:00:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 441481 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE17C433B4 for ; Mon, 17 May 2021 20:00:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31C06611ED for ; Mon, 17 May 2021 20:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237040AbhEQUB2 (ORCPT ); Mon, 17 May 2021 16:01:28 -0400 Received: from smtp-35.italiaonline.it ([213.209.10.35]:38706 "EHLO libero.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S236924AbhEQUB2 (ORCPT ); Mon, 17 May 2021 16:01:28 -0400 Received: from passgat-Modern-14-A10M.homenet.telecomitalia.it ([95.244.94.151]) by smtp-35.iol.local with ESMTPA id ijPJlPskepK9wijPOlg8K1; Mon, 17 May 2021 22:00:10 +0200 x-libjamoibt: 1601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libero.it; s=s2021; t=1621281610; bh=bmTisJb+Ff59TMYcwLQsU4X2sboin/EAdkin3u48soc=; h=From; b=ipCc4zaacXyEz5YcaJpohSdlkNoXd9Fg/nq+WS/nTGAEH6xiPFc/3iKC4HZbBR4Zt 2rzEsravy7ij50oKlYhsSuKCrdYdwpTDH69cby/+dMJKDeT9JEdqbKw572jWPTt/5c ERT9oeUKjcVUKjZ7N+eijMI0een+bDhV6MfjPsDl2HjF7We0NNHOuw4l9Iyxgqk0gM tBKbg2QlVTVjtK93+KQH1ABAB9z9lcnhWFFST8vka5P637kZHIIPYdTZE8YiPcPMf/ FQfNpiuYSCSKg2+YX9tgQ5iIFxohLS9vH/06+u3+5w322CeM0yz4sHTIkdgLXUpb07 /NAd7CP5sIppw== X-CNFS-Analysis: v=2.4 cv=A9ipg4aG c=1 sm=1 tr=0 ts=60a2cb4a cx=a_exe a=ugxisoNCKEotYwafST++Mw==:117 a=ugxisoNCKEotYwafST++Mw==:17 a=iV3ucFmErjs7te-rZ_sA:9 From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Linus Walleij , linux-gpio@vger.kernel.org Subject: [PATCH v2 1/2] pinctrl: core: configure pinmux from pins debug file Date: Mon, 17 May 2021 22:00:01 +0200 Message-Id: <20210517200002.6316-2-dariobin@libero.it> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210517200002.6316-1-dariobin@libero.it> References: <20210517200002.6316-1-dariobin@libero.it> X-CMAE-Envelope: MS4xfLx0TcvsHrcNzWtXVUq2wnkrd0xhmWrjEbSoW6Ku1Z8AF22pM/q3NjEFbkV2TsjpISAkxXAtRiSkOL2CLimlcchLMAld5RvLTAWjmgu41doM+ugAko0U Pf0V2GaozQMdFjBk+I0BEY75PO6EApb0dptS1qg5PBHWnivCmaQRHoHLMxGQ8MJeWkxgN0MI61rTWWze+zMefaIWVWX+4Gp0g7CA6Rl+7wewgShlEj3WalQv FC5HS7e8A73VJwSdlrhMBqs4OdadZNSCUSgDI7g6BlRc9RAIMgykgaErsjJQQ3IFiHJwubEqLaU0YQOrLcyhl47wU6oIjg/7x+4VWHBwazhfgqOsPAa0wvw3 a0YU3G09 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The MPUs of some architectures (e.g AM335x) must be in privileged operating mode to write on the pinmux registers. In such cases, where writes will not work from user space, now it can be done from the pins debug file if the platform driver exports the pin_dbg_set() helper among the registered operations. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/pinctrl/core.c | 56 +++++++++++++++++++++++++++++++-- include/linux/pinctrl/pinctrl.h | 2 ++ 2 files changed, 56 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index a4ac87c8b4f8..f5c9a7d44039 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -1620,6 +1620,46 @@ EXPORT_SYMBOL_GPL(pinctrl_pm_select_idle_state); #ifdef CONFIG_DEBUG_FS +static ssize_t pinctrl_pins_write(struct file *file, + const char __user *user_buf, size_t count, + loff_t *ppos) +{ + struct seq_file *s = file->private_data; + struct pinctrl_dev *pctldev = s->private; + const struct pinctrl_ops *ops = pctldev->desc->pctlops; + char buf[32]; + char *c = &buf[0]; + char *token; + int ret, buf_size; + unsigned int i, pin; + + if (!ops->pin_dbg_set) + return -EFAULT; + + /* Get userspace string and assure termination */ + buf_size = min(count, sizeof(buf) - 1); + if (copy_from_user(buf, user_buf, buf_size)) + return -EFAULT; + + buf[buf_size] = 0; + token = strsep(&c, " "); + if (kstrtouint(token, 0, &pin)) + return -EINVAL; + + for (i = 0; i < pctldev->desc->npins; i++) { + if (pin != pctldev->desc->pins[i].number) + continue; + + ret = ops->pin_dbg_set(pctldev, pin, c); + if (ret) + return ret; + + return count; + } + + return -EINVAL; +} + static int pinctrl_pins_show(struct seq_file *s, void *what) { struct pinctrl_dev *pctldev = s->private; @@ -1677,7 +1717,11 @@ static int pinctrl_pins_show(struct seq_file *s, void *what) return 0; } -DEFINE_SHOW_ATTRIBUTE(pinctrl_pins); + +static int pinctrl_pins_open(struct inode *inode, struct file *file) +{ + return single_open(file, pinctrl_pins_show, inode->i_private); +} static int pinctrl_groups_show(struct seq_file *s, void *what) { @@ -1886,6 +1930,14 @@ static int pinctrl_show(struct seq_file *s, void *what) } DEFINE_SHOW_ATTRIBUTE(pinctrl); +static const struct file_operations pinctrl_pins_fops = { + .open = pinctrl_pins_open, + .read = seq_read, + .write = pinctrl_pins_write, + .llseek = seq_lseek, + .release = single_release, +}; + static struct dentry *debugfs_root; static void pinctrl_init_device_debugfs(struct pinctrl_dev *pctldev) @@ -1915,7 +1967,7 @@ static void pinctrl_init_device_debugfs(struct pinctrl_dev *pctldev) dev_name(pctldev->dev)); return; } - debugfs_create_file("pins", 0444, + debugfs_create_file("pins", 0644, device_root, pctldev, &pinctrl_pins_fops); debugfs_create_file("pingroups", 0444, device_root, pctldev, &pinctrl_groups_fops); diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h index 70b45d28e7a9..6db4a775f549 100644 --- a/include/linux/pinctrl/pinctrl.h +++ b/include/linux/pinctrl/pinctrl.h @@ -95,6 +95,8 @@ struct pinctrl_ops { unsigned *num_pins); void (*pin_dbg_show) (struct pinctrl_dev *pctldev, struct seq_file *s, unsigned offset); + int (*pin_dbg_set) (struct pinctrl_dev *pctldev, unsigned int offset, + char *buf); int (*dt_node_to_map) (struct pinctrl_dev *pctldev, struct device_node *np_config, struct pinctrl_map **map, unsigned *num_maps);