From patchwork Thu Dec 10 06:50:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Troy Lee X-Patchwork-Id: 341384 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 584ACC4361B for ; Thu, 10 Dec 2020 06:51:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1989E22D0A for ; Thu, 10 Dec 2020 06:51:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387520AbgLJGvM (ORCPT ); Thu, 10 Dec 2020 01:51:12 -0500 Received: from twspam01.aspeedtech.com ([211.20.114.71]:33427 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730364AbgLJGvC (ORCPT ); Thu, 10 Dec 2020 01:51:02 -0500 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 0BA6lCla046149; Thu, 10 Dec 2020 14:47:12 +0800 (GMT-8) (envelope-from troy_lee@aspeedtech.com) Received: from TroyLee-PC.localdomain (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 10 Dec 2020 14:50:07 +0800 From: Troy Lee To: , Linus Walleij , Bartosz Golaszewski , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list CC: , , , Subject: [PATCH] gpio: aspeed: Lock GPIO pin used as IRQ Date: Thu, 10 Dec 2020 14:50:13 +0800 Message-ID: <20201210065013.29348-1-troy_lee@aspeedtech.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 0BA6lCla046149 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org GPIO pins can be used as IRQ indicators. When they do, those pins should be flaged with locks to avoid kernel warning message. Signed-off-by: Chia-Wei, Wang Signed-off-by: Troy Lee --- drivers/gpio/gpio-aspeed.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index b966f5e28ebf..f5b3e1d89fbf 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -651,6 +651,13 @@ static int aspeed_gpio_set_type(struct irq_data *d, unsigned int type) aspeed_gpio_copro_release(gpio, offset); spin_unlock_irqrestore(&gpio->lock, flags); + rc = gpiochip_lock_as_irq(&gpio->chip, d->hwirq); + if (rc) { + dev_err(gpio->chip.parent, "unable to lock GPIO %lu as IRQ\n", + d->hwirq); + return rc; + } + irq_set_handler_locked(d, handler); return 0;