From patchwork Mon Jul 13 14:49:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235436 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp2906534ilg; Mon, 13 Jul 2020 07:50:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxu8M37vtJ90RDX3epmCTvyKH6kOa71MEfzM8MTHGuYMt5jihGrc9glT8ysRHHlFazcCRD3 X-Received: by 2002:aa7:c2cf:: with SMTP id m15mr65157630edp.27.1594651828272; Mon, 13 Jul 2020 07:50:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594651828; cv=none; d=google.com; s=arc-20160816; b=S0oIIAFoxe0cMGvfwKAQjOTk8J6UZjGiPu5A3KRq+c/UHos/XWNo6VZDdB6mZ2Cho3 UFjSjrZi9T1SMmMT80iHKEv/UOj6W/pI01YyWwgmi7++UrWOAJ0uiLypnomn+G4o/iNS 1rTSP8wCPSQZbBOzXnxDnjRVKTeofHwhdXyhTYIeWMzHa1Tp7IqNG4djHY4uAACH92tD nByUIPF2nlgfONxti4oCAOyQ2BibhRc2WZi6YYkgHHa3cE7BbWtiDW89d7IiW6eRGU2d urjxRBKnO6+0w/ObnubbUUcoRDnga4S64SLiLR/WwmUK0qC3/j980DQiLx/kddtFk8SV BCSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uKRsk38fGN1JQaMOEwt3q4K2iQCr73XGMAa+Q9xdB5Q=; b=ZXMFDWBmSWSpb22EmNFuUxXCsUp6zzPjU82hgBd4vawNxR2G8nfndDeuFPvEgFcpNO SSAZUtf+dfuY+uXQvQY5N9iR/LuOuVz4KDQ6blBtPFZ7swoByk6Ajw/XP9Ajz+FF9tWd 9RYZrjfdpakCazguxVYzQHahrgDGOjNPoAGWHKOD0wfwLilNV/YBq9zsMVvIHaUDzJRe xDpxbGDmVrAIYsknEqYOIE2T1iNbR+dwpYfmACd5ogIihzn0LRChAWRxbgl8/6gUs4uT OeSENndLBJa8sNYIxM7SxCd0gB59gJiBKI5PgYnds7oGpJ7w+vdLOSMf3HNNPzfV8Nah MhLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="K/YUcN3S"; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bz8si8460771ejc.744.2020.07.13.07.50.28; Mon, 13 Jul 2020 07:50:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="K/YUcN3S"; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730280AbgGMOuV (ORCPT + 5 others); Mon, 13 Jul 2020 10:50:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730215AbgGMOt6 (ORCPT ); Mon, 13 Jul 2020 10:49:58 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F3F7C061755 for ; Mon, 13 Jul 2020 07:49:58 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id s10so16822403wrw.12 for ; Mon, 13 Jul 2020 07:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uKRsk38fGN1JQaMOEwt3q4K2iQCr73XGMAa+Q9xdB5Q=; b=K/YUcN3S/tmWmQag6LOp3T4Wg5FcOqEZ2W68vMLFZnK3d2+l3OM3sJbS1KNAwxvObA yhgx0ONPgbSIqN29/qTMXHszJo+yhnWHubNp4XhN/Y0Oh43t6VCWnvQqZAIET/tQ+0SZ oxMCUDvbWGHGL+WpFqB25XsXSsgB7tBgo/DIAxHg6rK9I+BNgxOjBAkIxXpyV7UNeYB7 QwOcvXHkd+2h8aNEugFElcNM4xoYN3H8MAk2A689KKaO9ZPujjAjcGwMPgidWkRfMhjB +V1enrSSdKh7uQfFPqGYlTFLnQadmk+yy8A+RDLqeWd6K64kdG/9w67b0Fu1XZUZfazE kjSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uKRsk38fGN1JQaMOEwt3q4K2iQCr73XGMAa+Q9xdB5Q=; b=me1zWdlQevQFh1YNk13YF/abnLEgB1//mnlhAINP9X3fpIYcV91vjR+1WqQW/0GeD+ S9I64buQfgjTBPcc2+qZ0g5ns413olqPblwLvj3ZnHhth7SKTl7iC/0Z9JnLtkXN5Ays UJP7jQLfBfhwbwYuzMi6DfoHUmkuehcseYOucljiBATVja1ZFZYQK1ctQ1QEIdB0P0lx WYzqYzvRZYMWHiE7qlLq9zvhFpYXVz3KBDYcXpPjb64mrw4jGOWVEb9+RxN2Uc3aGxPU QzGmbouwUw/f3No1YUalO8xXEa20fGteSDJohhipH6Pk69MzUA8BSmtLEv9qI24ej+N6 8vkA== X-Gm-Message-State: AOAM532I7j6gBVTITUiIfqiMUn3/+fdEFjz55yOrIL7V2TjmMynJBeQh 1zgJ3TvlLopcp6WmQNc3lWdegQ== X-Received: by 2002:adf:f608:: with SMTP id t8mr81988741wrp.308.1594651797153; Mon, 13 Jul 2020 07:49:57 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.6]) by smtp.gmail.com with ESMTPSA id o29sm26207756wra.5.2020.07.13.07.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 07:49:56 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org Subject: [PATCH 22/25] pinctrl: tegra: pinctrl-tegra194: Do not initialise field twice Date: Mon, 13 Jul 2020 15:49:27 +0100 Message-Id: <20200713144930.1034632-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200713144930.1034632-1-lee.jones@linaro.org> References: <20200713144930.1034632-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Both PIN_PINGROUP_ENTRY_Y() and DRV_PINGROUP_ENTRY_Y() macros are called for each of the 2 pin groups defined here, and both of them initialise 'drv_reg', causing the compiler to complain. Only initialise 'drv_reg' once. Fixes the following W=1 kernel build warning(s): drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: warning: initialized field overwritten [-Woverride-init] 71 | .drv_reg = ((r)), | ^ drivers/pinctrl/tegra/pinctrl-tegra194.c:105:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 105 | DRV_PINGROUP_ENTRY_Y(0x14004, 12, 5, 20, 5, -1, -1, -1, -1, 0) | ^~~~~~~~~~~~~~~~~~~~ drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_clkreq_n_pgg0’ 124 | drive_##pg_name, | ^~~~~~ drivers/pinctrl/tegra/pinctrl-tegra194.c:128:2: note: in expansion of macro ‘PINGROUP’ 128 | PINGROUP(pex_l5_clkreq_n_pgg0, PE5, RSVD1, RSVD2, RSVD3, 0x14000, 0, | ^~~~~~~~ drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: note: (near initialization for ‘tegra194_groups[0].drv_reg’) 71 | .drv_reg = ((r)), | ^ drivers/pinctrl/tegra/pinctrl-tegra194.c:105:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 105 | DRV_PINGROUP_ENTRY_Y(0x14004, 12, 5, 20, 5, -1, -1, -1, -1, 0) | ^~~~~~~~~~~~~~~~~~~~ drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_clkreq_n_pgg0’ 124 | drive_##pg_name, | ^~~~~~ drivers/pinctrl/tegra/pinctrl-tegra194.c:128:2: note: in expansion of macro ‘PINGROUP’ 128 | PINGROUP(pex_l5_clkreq_n_pgg0, PE5, RSVD1, RSVD2, RSVD3, 0x14000, 0, | ^~~~~~~~ drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: warning: initialized field overwritten [-Woverride-init] 71 | .drv_reg = ((r)), | ^ drivers/pinctrl/tegra/pinctrl-tegra194.c:107:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 107 | DRV_PINGROUP_ENTRY_Y(0x1400c, 12, 5, 20, 5, -1, -1, -1, -1, 0) | ^~~~~~~~~~~~~~~~~~~~ drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_rst_n_pgg1’ 124 | drive_##pg_name, | ^~~~~~ drivers/pinctrl/tegra/pinctrl-tegra194.c:130:2: note: in expansion of macro ‘PINGROUP’ 130 | PINGROUP(pex_l5_rst_n_pgg1, PE5, RSVD1, RSVD2, RSVD3, 0x14008, 0, | ^~~~~~~~ drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: note: (near initialization for ‘tegra194_groups[1].drv_reg’) 71 | .drv_reg = ((r)), | ^ drivers/pinctrl/tegra/pinctrl-tegra194.c:107:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 107 | DRV_PINGROUP_ENTRY_Y(0x1400c, 12, 5, 20, 5, -1, -1, -1, -1, 0) | ^~~~~~~~~~~~~~~~~~~~ drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_rst_n_pgg1’ 124 | drive_##pg_name, | ^~~~~~ drivers/pinctrl/tegra/pinctrl-tegra194.c:130:2: note: in expansion of macro ‘PINGROUP’ 130 | PINGROUP(pex_l5_rst_n_pgg1, PE5, RSVD1, RSVD2, RSVD3, 0x14008, 0, | ^~~~~~~~ Cc: Thierry Reding Cc: Jonathan Hunter Cc: linux-tegra@vger.kernel.org Signed-off-by: Lee Jones --- drivers/pinctrl/tegra/pinctrl-tegra194.c | 1 - 1 file changed, 1 deletion(-) -- 2.25.1 Acked-by: Thierry Reding diff --git a/drivers/pinctrl/tegra/pinctrl-tegra194.c b/drivers/pinctrl/tegra/pinctrl-tegra194.c index 2e0b5f7bb095b..c94ba17243c87 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra194.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra194.c @@ -98,7 +98,6 @@ static struct tegra_function tegra194_functions[] = { .sfsel_bit = 10, \ .schmitt_bit = schmitt_b, \ .drvtype_bit = 13, \ - .drv_reg = -1, \ .parked_bitmask = 0 #define drive_pex_l5_clkreq_n_pgg0 \