[10/18] gpio: sch311x: Implement open drain support

Message ID	20180629063544.3826-10-linus.walleij@linaro.org
State	Accepted
Commit	4455a82a400ba462db8abb642c670555d505bccc
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; From: Linus Walleij <linus.walleij@linaro.org> To: linux-gpio@vger.kernel.org Cc: Linus Walleij <linus.walleij@linaro.org>, Bruno Randolf <br1@einfach.org> Subject: [PATCH 10/18] gpio: sch311x: Implement open drain support Date: Fri, 29 Jun 2018 08:35:36 +0200 Message-Id: <20180629063544.3826-10-linus.walleij@linaro.org> In-Reply-To: <20180629063544.3826-1-linus.walleij@linaro.org> References: <20180629063544.3826-1-linus.walleij@linaro.org> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk
Series	[01/18] gpio: rc5t583: Include the right header \| expand [01/18] gpio: rc5t583: Include the right header [02/18] gpio: rcar: Include the right header [03/18] gpio: rdc321x: Include the right header [04/18] gpio: sa1100: Include the right header [05/18] gpio: sch: Include the right header [06/18] gpio: sch: Implement .get_direction() [07/18] gpio: sch311x: Include the right header [08/18] gpio: sch311x: Implement .get_direction() [09/18] gpio: sch311x: Use RMW to change direction [10/18] gpio: sch311x: Implement open drain support [11/18] gpio: sch311x: Replace unsigned char with u8 [12/18] gpio: spear-spics: Include the right header [13/18] gpio: sta2x11: Include the right header [14/18] gpio: sta2x11: Use BIT() macro [15/18] gpio: sta2x11: Inline regs macro [16/18] gpio: stmpe: Include the right header [17/18] gpio: stp-xway: Include the right header [18/18] gpio: syscon: Include the right header

Message ID

20180629063544.3826-10-linus.walleij@linaro.org

State

Accepted

Commit

4455a82a400ba462db8abb642c670555d505bccc

Headers

Received-SPF: pass (google.com: best guess record for domain of
	linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as
	permitted sender) client-ip=209.132.180.67; 
From: Linus Walleij <linus.walleij@linaro.org>
To: linux-gpio@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>, Bruno Randolf <br1@einfach.org>
Subject: [PATCH 10/18] gpio: sch311x: Implement open drain support
Date: Fri, 29 Jun 2018 08:35:36 +0200
Message-Id: <20180629063544.3826-10-linus.walleij@linaro.org>
In-Reply-To: <20180629063544.3826-1-linus.walleij@linaro.org>
References: <20180629063544.3826-1-linus.walleij@linaro.org>
Sender: linux-gpio-owner@vger.kernel.org
Precedence: bulk

Series

[01/18] gpio: rc5t583: Include the right header | expand

Commit Message

Linus Walleij June 29, 2018, 6:35 a.m. UTC

The chip has a bit for controlling open drain, and it is
easy to implement the callback to support open drain when
needed, so let's implement it.

Cc: Bruno Randolf <br1@einfach.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 drivers/gpio/gpio-sch311x.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

-- 
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/drivers/gpio/gpio-sch311x.c b/drivers/gpio/gpio-sch311x.c
index faf44178f97b..1d2af9f97a91 100644
--- a/drivers/gpio/gpio-sch311x.c
+++ b/drivers/gpio/gpio-sch311x.c
@@ -235,6 +235,34 @@  static int sch311x_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
 	return !!(data & SCH311X_GPIO_CONF_DIR);
 }
 
+static int sch311x_gpio_set_config(struct gpio_chip *chip, unsigned offset,
+				   unsigned long config)
+{
+	struct sch311x_gpio_block *block = gpiochip_get_data(chip);
+	enum pin_config_param param = pinconf_to_config_param(config);
+	unsigned char data;
+
+	switch (param) {
+	case PIN_CONFIG_DRIVE_OPEN_DRAIN:
+		spin_lock(&block->lock);
+		data = inb(block->runtime_reg + block->config_regs[offset]);
+		data |= SCH311X_GPIO_CONF_OPEN_DRAIN;
+		outb(data, block->runtime_reg + block->config_regs[offset]);
+		spin_unlock(&block->lock);
+		return 0;
+	case PIN_CONFIG_DRIVE_PUSH_PULL:
+		spin_lock(&block->lock);
+		data = inb(block->runtime_reg + block->config_regs[offset]);
+		data &= ~SCH311X_GPIO_CONF_OPEN_DRAIN;
+		outb(data, block->runtime_reg + block->config_regs[offset]);
+		spin_unlock(&block->lock);
+		return 0;
+	default:
+		break;
+	}
+	return -ENOTSUPP;
+}
+
 static int sch311x_gpio_probe(struct platform_device *pdev)
 {
 	struct sch311x_pdev_data *pdata = dev_get_platdata(&pdev->dev);
@@ -268,6 +296,7 @@  static int sch311x_gpio_probe(struct platform_device *pdev)
 		block->chip.direction_input = sch311x_gpio_direction_in;
 		block->chip.direction_output = sch311x_gpio_direction_out;
 		block->chip.get_direction = sch311x_gpio_get_direction;
+		block->chip.set_config = sch311x_gpio_set_config;
 		block->chip.get = sch311x_gpio_get;
 		block->chip.set = sch311x_gpio_set;
 		block->chip.ngpio = 8;

[10/18] gpio: sch311x: Implement open drain support

Commit Message

Patch