From patchwork Mon Mar 19 00:50:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 131980 Delivered-To: patch@linaro.org Received: by 10.46.84.17 with SMTP id i17csp2139688ljb; Sun, 18 Mar 2018 17:51:21 -0700 (PDT) X-Google-Smtp-Source: AG47ELtCbVqu9Zir3NaMgHQ0UxHmSC14MkGw06n1CPHlRk1N47vQgKUeC3c6s0Kta5Czc8XAssCO X-Received: by 10.99.181.10 with SMTP id y10mr7800092pge.222.1521420681236; Sun, 18 Mar 2018 17:51:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521420681; cv=none; d=google.com; s=arc-20160816; b=PYI25KwomzO7RUie79gA8LFVYLKJhvL+62ewbjx5cliD0cHVsxI03T2nootIlzcGTy 4kyu91mOPZlqdx930vcrOXqo+OltGzy6sYrEmBEb6HrW3n/F7qqq2yyZFNB1TYRpkn8J oqiPU+1k5AOtDezZf/bgFgWQH81rVJ0YbqbLmm8AL0MKpA1BBXAt06cu82SvGEvPBpTi c4ZZtDLnz4DjD6Sx/pk3PpnLCQUFelzkbev7gkBASc1O8K3kV/PqAxIcio6PDIN5TlbB XK5rYrRBOcH3FjxIL5ejbdNmZ5mhKq4Da9+0mAXh0rj9cXwNTgxxpRj2xnfvl2tfOWc5 3Npg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=ioTsi2N2AoletBY5cAnH76tCwfWUhQuYP7y8rH1jMCU=; b=vdbqeXckW7cGoiQR9HEjcRjBcLqOmNOp6ibXxE5eRvFpOReO+P9Pq1/JNNbkkUyd85 +dXMyD5HB5TisAMeBvlDckVh2llGp9hxY10KO29dpzeZXKvbmsxzM55X7AU44qp8Z8wM /CqYAfl5bM0vLrnwPvlXZaCoJXcti8sjJRprft7hktCBs05IejN6YAtr/fCivlf5VsYK 7h6nspqDYRVSrZXkhFD6wIQGVABfux0a+GXKpxJSrf+CRdytuWk5on+/swslyr+9/60L VMzPsewnz7YNwjBTRWzrMBiSgJdeMpSJ7zZ2tShjUf1NraP5Ckc6zBTsYGhccsM9JtN4 mgYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=P0cgJOjR; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z9si4038677pgo.720.2018.03.18.17.51.21; Sun, 18 Mar 2018 17:51:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=P0cgJOjR; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754776AbeCSAvU (ORCPT + 5 others); Sun, 18 Mar 2018 20:51:20 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:39606 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754673AbeCSAvU (ORCPT ); Sun, 18 Mar 2018 20:51:20 -0400 Received: by mail-pg0-f66.google.com with SMTP id a19so462993pgw.6 for ; Sun, 18 Mar 2018 17:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M25aTOG2S2LRQPtzWhbRDMp6/Y4MwBXeB+71RTBVOq4=; b=P0cgJOjRorHi99KX+TldV+XIJ8pOLxGj2s/YprjZycLP2i6EpMPuY4D8fZxpIjXv+P hfxmVGGmonf8qkoYdd9ulr9pJsPiMRt5URlQd05gl7UDqLDY9ZIcePstP231oIk9t90R VNgiSMvw9CwI5uvGumrlgmMk/cacjtHRHqoWA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M25aTOG2S2LRQPtzWhbRDMp6/Y4MwBXeB+71RTBVOq4=; b=t7DBSlWpYTKE3rNpLsr25Ej5KY+ewb5Mkfv58our/3OfR9+R7GzjA3nmBRmcKgeopW HIFERwWAOVxANomr05b5f2upgEmCnO6aRx4U9YinYanp7hGF7XPahzIJppjXtqviQ74U Yqgy/OU1uRfoRL4Kep4YYy79mSGVVqtwxG30MmGpNsB2J1fgdBcn2UN5Z/+DUlbmTkii 1PBLSEr+yrdyEFVPcj3jb81pAfpnfygtib05K0QrVMAeiTE/GIRX2j2T8thAMJ8amuH0 nZUVrZVCbjRF02am0EgtlEo2T/c3I/Pg5DPd9eO5P9IxwvrmkGgHacpck3BRmheXgSRQ QQrg== X-Gm-Message-State: AElRT7EXe5gTcADl+wt5WUfB+6Nmz18uwqCRm6BJeTSbXwljUE1TGMrE 7RyVegwkT8fHVF08JIhDp/ZgnfpIy2z3hw== X-Received: by 10.167.129.24 with SMTP id b24mr8523883pfi.183.1521420679376; Sun, 18 Mar 2018 17:51:19 -0700 (PDT) Received: from localhost.localdomain ([218.255.99.6]) by smtp.gmail.com with ESMTPSA id z15sm21766373pgr.68.2018.03.18.17.51.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Mar 2018 17:51:18 -0700 (PDT) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Linus Walleij Subject: [PATCH 07/13] gpio: ich: Include the right header Date: Mon, 19 Mar 2018 01:50:50 +0100 Message-Id: <20180319005056.7380-7-linus.walleij@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180319005056.7380-1-linus.walleij@linaro.org> References: <20180319005056.7380-1-linus.walleij@linaro.org> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This driver is a pure GPIO driver and should only include . Refrain from using GPIOF_* flags in the driver, just use 1/0 to return direction. Signed-off-by: Linus Walleij --- drivers/gpio/gpio-ich.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.14.3 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c index 4f6d643516b7..7a54165d7276 100644 --- a/drivers/gpio/gpio-ich.c +++ b/drivers/gpio/gpio-ich.c @@ -23,7 +23,7 @@ #include #include #include -#include +#include #include #include @@ -176,7 +176,7 @@ static bool ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr) static int ichx_gpio_get_direction(struct gpio_chip *gpio, unsigned nr) { - return ichx_read_bit(GPIO_IO_SEL, nr) ? GPIOF_DIR_IN : GPIOF_DIR_OUT; + return ichx_read_bit(GPIO_IO_SEL, nr); } static int ichx_gpio_direction_input(struct gpio_chip *gpio, unsigned nr)