From patchwork Wed Sep 14 10:13:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101795 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp1794024qgf; Wed, 14 Sep 2016 03:14:09 -0700 (PDT) X-Received: by 10.98.66.212 with SMTP id h81mr2985558pfd.51.1473848049554; Wed, 14 Sep 2016 03:14:09 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id vu8si4060940pab.180.2016.09.14.03.14.09; Wed, 14 Sep 2016 03:14:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751621AbcINKOI (ORCPT + 4 others); Wed, 14 Sep 2016 06:14:08 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:54774 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755829AbcINKOH (ORCPT ); Wed, 14 Sep 2016 06:14:07 -0400 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002) with ESMTPA (Nemesis) id 0LtzaY-1b3wPI1j0w-011P2n; Wed, 14 Sep 2016 12:13:26 +0200 From: Arnd Bergmann To: Linus Walleij Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Arnd Bergmann , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: stm32: add IRQ_DOMAIN_HIERARCHY dependency Date: Wed, 14 Sep 2016 12:13:06 +0200 Message-Id: <20160914101323.3254566-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:jWTuupXrqIM8MtSnnwmjc7xfZ8tKhmgBCcobElIzSU8VGNIrZdB 0hSaDZv4+r2Uky9h8x0iiVjMjf4hfPGA3K0aYBLj908/LuDPtLUIZ3XBZ8v2H8Y1X2/WUmX SGhp1sbaX74I51RU35SP0gXLy45BBvFTOqO5MWmUr50olBH+5R83nm/VanRYmavOwejLF5k XsqA8N0avjzMlBpNPQakg== X-UI-Out-Filterresults: notjunk:1; V01:K0:dNQamQW/BGI=:sqIosMJJpLkuoe7TF8dXGh 3LXru7QxK7vW9GYAh/7E48tEdtfeDCRrAKojp3lzvDTHsqQSmFHCfuUZHx2p04BjH/Gvm3w2/ BRYf0MBf4Dvk0rGubXc3KYqDmqeHN8Oi6+LSMRDuGtSIdAn+sIzirnNaAUzZGAt2JQ2Pid88Q 4CHUZXvZQ3GIzknRANtAuZoCHKOqAVB3r5BBuQtOqEk0D0qALguCWa42qIZauNDWIXiLA/mXi k0NRCbJpDahz1UkSWrGwCE9WK9F1NGZVmMegYfJjCJqrETulU4QwEtpiYj6bdtKaBjWVJ3Vli s3TsAAL9fihzvl7pFLnLgqhbxtMjAJG4/iYpu90L8LmqZJuKnnMEpNSmVyh7vFbtb/urQ44x2 A+ALwoA6epogG6TQe+ciL/eGvDaEMx8orcPlA+Wm5n9kVG3xAqR5y5YQlS9dgmyPgz9SsNqRj M2wRh6Z0VPZrQPcvb9mK4ymwNmisf0uduo6oZW0ca74mnARu5l9/N41uNhJP5O+3TYrJn3hRR l6KAr8oiLrlI+Gpbg35yGH7Pr90H76cyOLSYDqdiaGlNT1nF+tkEg2FJ3KTC987opFnl4Zim+ ZNAiIVba9UZR8JORXpb8UBA4nb2YyEkwP9GcUCb9Wb2sOMMIbduQ2m4+Zaie17/2GOuYq+NsK H5C6W6QCN253Rccb0qCHD8uyvncrgwKxggUuHJ3BQhbuB/1KMzrf8CfybfJAVl0aUI5o= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The newly added irqchip support for the stm32 pinctrl driver uses hierarchical IRQ domains as provided by the NVIC primary irqchip. This works great for any configuration that may be relevant on stm32, but when doing compile-testing (randconfig), we can enable it without NVIC or any other primary irqchip that enables IRQ_DOMAIN_HIERARCHY: drivers/pinctrl/stm32/pinctrl-stm32.c:212:13: error: 'irq_chip_eoi_parent' undeclared here (not in a function) drivers/pinctrl/stm32/pinctrl-stm32.c:213:20: error: 'irq_chip_mask_parent' undeclared here (not in a function) drivers/pinctrl/stm32/pinctrl-stm32.c:214:20: error: 'irq_chip_unmask_parent' undeclared here (not in a function) drivers/pinctrl/stm32/pinctrl-stm32.c:215:20: error: 'irq_chip_set_type_parent' undeclared here (not in a function) This adds a Kconfig dependency to limit compile-testing to configurations that have IRQ_DOMAIN_HIERARCHY already enabled. It's not obvious whether we should use 'depends on' or 'select' here, I think either one works, with 'depends on' being more intuitive, while 'select' would be less likely to cause dependency loops. Signed-off-by: Arnd Bergmann Fixes: 0eb9f683336d ("pinctrl: Add IRQ support to STM32 gpios") --- drivers/pinctrl/stm32/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig index 24bc68308af2..c03dce7a22df 100644 --- a/drivers/pinctrl/stm32/Kconfig +++ b/drivers/pinctrl/stm32/Kconfig @@ -10,13 +10,13 @@ config PINCTRL_STM32 config PINCTRL_STM32F429 bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429 - depends on OF + depends on OF && IRQ_DOMAIN_HIERARCHY default MACH_STM32F429 select PINCTRL_STM32 config PINCTRL_STM32F746 bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746 - depends on OF + depends on OF && IRQ_DOMAIN_HIERARCHY default MACH_STM32F746 select PINCTRL_STM32