From patchwork Thu Nov 17 08:47:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 82668 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp625677qge; Thu, 17 Nov 2016 00:47:12 -0800 (PST) X-Received: by 10.98.159.67 with SMTP id g64mr3089484pfe.93.1479372432838; Thu, 17 Nov 2016 00:47:12 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w8si2312817pgw.107.2016.11.17.00.47.12; Thu, 17 Nov 2016 00:47:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751567AbcKQIrK (ORCPT + 4 others); Thu, 17 Nov 2016 03:47:10 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38097 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbcKQIrJ (ORCPT ); Thu, 17 Nov 2016 03:47:09 -0500 Received: by mail-wm0-f41.google.com with SMTP id f82so130531127wmf.1 for ; Thu, 17 Nov 2016 00:47:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=5pgdi206IYSIQNu3784sFH/npSK+omokblRM56cWEWQ=; b=ksTaflAKXgKQmqFIOnv2sOPCqDW/8A+kdRNd6XRe3UNYUkTHQ4YKhie5rvTZalG4nz yqugxHJSXE4zwU/MI6AUMB0UQ4LLN8bV5PxpjxKH9wrKqjb8DSoPZAuCjU58JdkqqOSS ufoPhkc8SHhHR3vj8w6m/inti5sqdb8hYeJ/c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5pgdi206IYSIQNu3784sFH/npSK+omokblRM56cWEWQ=; b=mjDwiIW5aa1ztZtD39Xmj+yGDlt7ro7iaKB/NJ1ylG6xvI3pKx18r+MwfybW/N8KJO 1s6NnCdv3P3N5gaVkqrjZe7kP+MLel+Ndl/MgEfTsYs1fJkqCNyahGIHlcKNwodkpecd uaSbdeJOcZS/lO24oB96wE9xas0V7L7LYE9hCTz8tBcbXPOl2a/OoGvFq2wfciJ73zVD +4bnyip64IZ3ylwIE5AZIny7xEORZteAfGvlKny3LN4/6ZL7VW9xElNdmFw9BYwv+zoL x/lfgcPtFlMfXhFT39AulzPqBpaFnpaTsJrvCuLA5ca2KyZSGR5rzaBbRqWwdNDuNbDW wWrw== X-Gm-Message-State: ABUngve/BN+kHAf55+Kte7P6mVhJlmslnOtzun1RfC6EDNl7Z4ztAhL7RVOwn+Vib6CDUbO7 X-Received: by 10.25.21.205 with SMTP id 74mr287391lfv.138.1479372427853; Thu, 17 Nov 2016 00:47:07 -0800 (PST) Received: from linuslaptop.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id l141sm507939lfl.0.2016.11.17.00.47.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Nov 2016 00:47:07 -0800 (PST) From: Linus Walleij To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linux-gpio@vger.kernel.org, Linus Walleij Subject: [PATCH] pinctrl: nomadik: split up and comments MC0 pins Date: Thu, 17 Nov 2016 09:47:03 +0100 Message-Id: <1479372423-4065-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org When debugging it helps to see exactly which pin goes where, so make it very detailed. Signed-off-by: Linus Walleij --- drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c b/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c index 8392083514fb..af4814479eb0 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c @@ -379,13 +379,24 @@ static const unsigned msp0txrx_a_1_pins[] = { DB8500_PIN_AC4, DB8500_PIN_AC3 }; static const unsigned msp0tfstck_a_1_pins[] = { DB8500_PIN_AF3, DB8500_PIN_AE3 }; static const unsigned msp0rfsrck_a_1_pins[] = { DB8500_PIN_AD3, DB8500_PIN_AD4 }; /* Basic pins of the MMC/SD card 0 interface */ -static const unsigned mc0_a_1_pins[] = { DB8500_PIN_AC2, DB8500_PIN_AC1, - DB8500_PIN_AB4, DB8500_PIN_AA3, DB8500_PIN_AA4, DB8500_PIN_AB2, - DB8500_PIN_Y4, DB8500_PIN_Y2, DB8500_PIN_AA2, DB8500_PIN_AA1 }; +static const unsigned mc0_a_1_pins[] = { DB8500_PIN_AC2, /* MC0_CMDDIR */ + DB8500_PIN_AC1, /* MC0_DAT0DIR */ + DB8500_PIN_AB4, /* MC0_DAT2DIR */ + DB8500_PIN_AA3, /* MC0_FBCLK */ + DB8500_PIN_AA4, /* MC0_CLK */ + DB8500_PIN_AB2, /* MC0_CMD */ + DB8500_PIN_Y4, /* MC0_DAT0 */ + DB8500_PIN_Y2, /* MC0_DAT1 */ + DB8500_PIN_AA2, /* MC0_DAT2 */ + DB8500_PIN_AA1 /* MC0_DAT3 */ +}; /* Often only 4 bits are used, then these are not needed (only used for MMC) */ -static const unsigned mc0_dat47_a_1_pins[] = { DB8500_PIN_W2, DB8500_PIN_W3, - DB8500_PIN_V3, DB8500_PIN_V2}; -static const unsigned mc0dat31dir_a_1_pins[] = { DB8500_PIN_AB3 }; +static const unsigned mc0_dat47_a_1_pins[] = { DB8500_PIN_W2, /* MC0_DAT4 */ + DB8500_PIN_W3, /* MC0_DAT5 */ + DB8500_PIN_V3, /* MC0_DAT6 */ + DB8500_PIN_V2 /* MC0_DAT7 */ +}; +static const unsigned mc0dat31dir_a_1_pins[] = { DB8500_PIN_AB3 }; /* MC0_DAT31DIR */ /* MSP1 can only be on these pins, but TXD and RXD can be flipped */ static const unsigned msp1txrx_a_1_pins[] = { DB8500_PIN_AF2, DB8500_PIN_AG2 }; static const unsigned msp1_a_1_pins[] = { DB8500_PIN_AE1, DB8500_PIN_AE2 };