From patchwork Tue Aug 16 10:25:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 73987 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1917070qga; Tue, 16 Aug 2016 03:26:20 -0700 (PDT) X-Received: by 10.98.29.201 with SMTP id d192mr62439384pfd.142.1471343179613; Tue, 16 Aug 2016 03:26:19 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pl3si31579929pac.22.2016.08.16.03.26.19; Tue, 16 Aug 2016 03:26:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753273AbcHPK0S (ORCPT + 4 others); Tue, 16 Aug 2016 06:26:18 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38319 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbcHPK0Q (ORCPT ); Tue, 16 Aug 2016 06:26:16 -0400 Received: by mail-wm0-f41.google.com with SMTP id o80so157377185wme.1 for ; Tue, 16 Aug 2016 03:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=PkxpP0180iQYSE3S/DTK/+3crqueI/tgfjmKsUWQvR8=; b=Z4s7iYHUyix0k6QoP6829QSzAaBohEYM+A+DgdrfYQSCFKDlwmlM0mlaJfk6vV8sBa r6IjWM2owzzCrwsQrT3u1zox7QQWQqwB8pVJxqOYtfwtQbg5l1ec9qo/JLFP/9Goa3HC YEIq+W4Zfxb6/PGXMUDeuM+qayFsJ+UdO8Jn0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PkxpP0180iQYSE3S/DTK/+3crqueI/tgfjmKsUWQvR8=; b=W9M/1VcZEgTAmumtv4DA7ldp99SqxNFTuI+JCr+fQ7Goy1Mex1rrc75i3cmD1ge5lO SVrExAe6iCcbgXq382scIyLlLCAsinnWWZVMjwYgGpIp+ymEOeoWMERsOTYbiwNbyv9s H8RQJDa55eY+kTs50TUFbilXulTokNbKdAmT82gY8Uoh1TGlUXzEZsg5CFHpV/1/qqlH gvZVAXiHwRIgIdEZsyLcMFxb8gAVf/JbKcpvFfKA2Xnzm+bc+qq0M/XE7r1OaF1Urw08 Im18VGzHNpKBxAGvPGSIKHqsXR1ngu+8KBjKiNss2tYKDy+RskhKODvJcDLLuDD04HPA VhKw== X-Gm-Message-State: AEkooutFvPFMca05GThWBnLczUCsOwOlIH+T0L2hGTfbmi/L/3Lh+TsDV+MJD1xhdEk6118x X-Received: by 10.25.209.68 with SMTP id i65mr5746824lfg.20.1471343162973; Tue, 16 Aug 2016 03:26:02 -0700 (PDT) Received: from localhost.localdomain.localdomain (c-357171d5.014-348-6c756e10.cust.bredbandsbolaget.se. [213.113.113.53]) by smtp.gmail.com with ESMTPSA id 192sm705354ljf.17.2016.08.16.03.26.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Aug 2016 03:26:01 -0700 (PDT) From: Linus Walleij To: linux-gpio@vger.kernel.org, Alexandre Courbot Cc: Linus Walleij , Rabin Vincent , Pramod Gurav , Andreas Larsson , Gregory CLEMENT , Thierry Reding , Laxman Dewangan , Geert Uytterhoeven , Phil Reid Subject: [PATCH] gpio: make any OF dependent driver depend on OF_GPIO Date: Tue, 16 Aug 2016 12:25:57 +0200 Message-Id: <1471343157-30076-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The drivers that depend on OF but not OF_GPIO are wreaking havoc with the autobuilders for archs that have all requirements for OF but not for OF_GPIO, particularly the UM (Usermode) arch does not have iomem (NO_IOMEM) which result in configuring GPIOLIB but without OF_GPIO which is wrong if the driver is using the .of_node of the gpiochip, which only appears with OF_GPIO. After a brief look at the drivers just depending on OF it seems most if not all of them actually require stuff from gpiolib-of so the dependency is wrong in the first place. This simply patches the Kconfig so that all GPIO drivers using OF depend on OF_GPIO rather than just OF. Cc: Rabin Vincent Cc: Pramod Gurav Cc: Andreas Larsson Cc: Gregory CLEMENT Cc: Thierry Reding Cc: Laxman Dewangan Cc: Alexandre Courbot Cc: Geert Uytterhoeven Cc: Phil Reid Signed-off-by: Linus Walleij --- Driver maintainers: if you for some reason think that this is not good for your driver, tell me why. --- drivers/gpio/Kconfig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index a6026f2fe7f5..7f3aabc7ee10 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -189,7 +189,7 @@ config GPIO_EP93XX config GPIO_ETRAXFS bool "Axis ETRAX FS General I/O" depends on CRIS || COMPILE_TEST - depends on OF + depends on OF_GPIO select GPIO_GENERIC select GPIOLIB_IRQCHIP help @@ -215,7 +215,7 @@ config GPIO_GENERIC_PLATFORM config GPIO_GRGPIO tristate "Aeroflex Gaisler GRGPIO support" - depends on OF + depends on OF_GPIO select GPIO_GENERIC select IRQ_DOMAIN help @@ -313,7 +313,7 @@ config GPIO_MPC8XXX config GPIO_MVEBU def_bool y depends on PLAT_ORION - depends on OF + depends on OF_GPIO select GENERIC_IRQ_CHIP config GPIO_MXC @@ -406,7 +406,7 @@ config GPIO_TEGRA bool "NVIDIA Tegra GPIO support" default ARCH_TEGRA depends on ARCH_TEGRA || COMPILE_TEST - depends on OF + depends on OF_GPIO help Say yes here to support GPIO pins on NVIDIA Tegra SoCs. @@ -1100,7 +1100,7 @@ menu "SPI GPIO expanders" config GPIO_74X164 tristate "74x164 serial-in/parallel-out 8-bits shift register" - depends on OF + depends on OF_GPIO help Driver for 74x164 compatible serial-in/parallel-out 8-outputs shift registers. This driver can be used to provide access