From patchwork Tue Dec 22 14:30:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 58901 Delivered-To: patch@linaro.org Received: by 10.112.89.199 with SMTP id bq7csp3270476lbb; Tue, 22 Dec 2015 06:30:57 -0800 (PST) X-Received: by 10.66.227.1 with SMTP id rw1mr36384887pac.35.1450794657630; Tue, 22 Dec 2015 06:30:57 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dc17si4497352pac.86.2015.12.22.06.30.57; Tue, 22 Dec 2015 06:30:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932466AbbLVOa4 (ORCPT + 4 others); Tue, 22 Dec 2015 09:30:56 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:34715 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932139AbbLVOa4 (ORCPT ); Tue, 22 Dec 2015 09:30:56 -0500 Received: by mail-lf0-f45.google.com with SMTP id y184so130159373lfc.1 for ; Tue, 22 Dec 2015 06:30:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=1exYiy5OlQfFtk91+ecG7GKbmjoQL/9ORjcrGQcN5L0=; b=VTJrfHzJ8UMxuarPjfqX0vl+JGfUoObIPN9TPJqlGzMk3SF9BqhWV9OgCiTEMRnHgz EO3XiQNOqZ6dnpYO7WC4zVOFlwK/ocNeidzRLJiFR3XUGqzsKCadLzDPJbPvwUD76ix1 Exhd8Rc8ycCEfAqNtn5U6xNGucjLRbl8bRgco= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-type:content-transfer-encoding; bh=1exYiy5OlQfFtk91+ecG7GKbmjoQL/9ORjcrGQcN5L0=; b=BM0it3EknK1dKDB4s8jqT8b/k/8qTE1QDT8hNy7VGOcf+Wv0fxg97brxrO5iUzOMvB H2oHjAQPym65Z+MMAA+P5w+w5qWmyPgwoBRNbjKmcFlNqip8tKcwlEtDIvm3y+JsQc2T CJuC90gFHPmqNXH2O+s3YHCc5hb2yVP3Mf6FfSpJwAf65dBnB4UXZfxTSR8NinVZmF93 b/VCxPLWRh5MxEoq+v4EiVcT6hV6XCFF0mgRnZl+Ryip4xE0XDByrsIXeWOdnIlpT9rh jpBV2hCTvf7vgapOqzZ0RxUy/vQzf6DBG9+sujAq9THgjwuQyE1glTMtSMfM8epU+YxA vJug== X-Gm-Message-State: ALoCoQmRmGsCEq7TIZb2fezOJvhsKfygAYyNPYMi9NxFdGeWorr5axbXc2cm2PzKy1G2Jx12oXWvPR6tXnIZu8Eh7HSIf8jcsA== X-Received: by 10.25.162.65 with SMTP id l62mr8690395lfe.64.1450794655120; Tue, 22 Dec 2015 06:30:55 -0800 (PST) Received: from localhost.localdomain ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id y15sm5848962lfd.3.2015.12.22.06.30.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2015 06:30:54 -0800 (PST) From: Linus Walleij To: linux-gpio@vger.kernel.org, "Ivan T. Ivanov" , =?UTF-8?q?Bj=C3=B6rn=20Andersson?= Cc: Linus Walleij Subject: [PATCH 28/54] pinctrl: spmi-mpp: Be sure to clamp return value Date: Tue, 22 Dec 2015 15:30:52 +0100 Message-Id: <1450794652-23900-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 2.4.3 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Björn Andersson Cc: Ivan T. Ivanov Signed-off-by: Linus Walleij --- drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c index 69c14ba177d0..ea1d2b2f6fd1 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c @@ -591,7 +591,7 @@ static int pmic_mpp_get(struct gpio_chip *chip, unsigned pin) pad->out_value = ret & PMIC_MPP_REG_RT_STS_VAL_MASK; } - return pad->out_value; + return !!pad->out_value; } static void pmic_mpp_set(struct gpio_chip *chip, unsigned pin, int value)