From patchwork Wed Dec 9 10:06:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 57935 Delivered-To: patch@linaro.org Received: by 10.112.147.194 with SMTP id tm2csp567734lbb; Wed, 9 Dec 2015 02:06:26 -0800 (PST) X-Received: by 10.98.68.201 with SMTP id m70mr11680689pfi.101.1449655586438; Wed, 09 Dec 2015 02:06:26 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si11716566pfi.101.2015.12.09.02.06.26; Wed, 09 Dec 2015 02:06:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro-org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754156AbbLIKGY (ORCPT + 4 others); Wed, 9 Dec 2015 05:06:24 -0500 Received: from mail-lb0-f181.google.com ([209.85.217.181]:34901 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbbLIKGU (ORCPT ); Wed, 9 Dec 2015 05:06:20 -0500 Received: by lbpu9 with SMTP id u9so26699399lbp.2 for ; Wed, 09 Dec 2015 02:06:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=AhOCuUjnzMf6H5KDn0R3a1cybzrdWv0LnYpHSUhgxAA=; b=an9c88/Cz2EiS3a9qv1dwiT4sYszxfn4Iq+LrTbNXy1fIjQnhnNB7ZOCzsUuGBKGuy 0awPZK4/HffrqlPr1ZnxIyt3VXQPqYg4zwX4FhfKWVqeZlXv986aGBv8ZtvGSg4orPww Q2xRywQydiRbYRNZWA5m+GLX1VagWnZEX5GlYEUEJrQea6TLXnW3BtORqS+ba980vwTQ erof42B3dppKuubzrskXkCbMKqc1E/qFytiuAjjwnCIkgK1rD7mRdIQtuK34j1NDWOQ+ XCh+f1MhHoZOSx+TD2YK00ic/eS2TAeHW5gknQxOWQDOAeU+tylvTugGU8N4Qf7PJHKt We6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-type:content-transfer-encoding; bh=AhOCuUjnzMf6H5KDn0R3a1cybzrdWv0LnYpHSUhgxAA=; b=S5q0RS5FNuC3OLFtw+1VHeBBDILawXwWerOQKX2jPyjFqc7T8OmLbnYunO/ePolISe 3DUXHLtHpKG42aevTASSDj2d1wxb2NF6ZiuQPHcwrk1cPJGZb7MQBoPPAMSonmyr/mE5 3Qi7takKC+0LtWv710F9kdbF9wS8fWZYlv1KHHUaCpd3KqWqExuhucpzzvCtQgJW+00Y RRu5QAXmZt0PM/kALbf3eLV0OKWR5GaWHuyzOXvEDBOACsgw+gbkjWoQTG4CaniDK1tO +j5VoOTo8eLTrNekNAtX3XLq2n+4Ss0tkbb/Qaz1nJ6ph4l9RmGdNBq32nszJ/hhQnyY HJ9Q== X-Gm-Message-State: ALoCoQmtA73HE7juargTpImAoy+S0Iy/mMfbpkKzWaiZr+8WUNEfVt2QG0o/Sx1eDsn4gmHYTO8neAhqh9lrGDJK4AteQEpJRQ== X-Received: by 10.112.182.100 with SMTP id ed4mr2029951lbc.143.1449655578835; Wed, 09 Dec 2015 02:06:18 -0800 (PST) Received: from localhost.localdomain ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id m64sm1243380lfd.45.2015.12.09.02.06.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2015 02:06:18 -0800 (PST) From: Linus Walleij To: linux-gpio@vger.kernel.org, Alexandre Courbot Cc: Linus Walleij , Ben Dooks Subject: [PATCH] gpio: pca953x: make inclusion of unconditional Date: Wed, 9 Dec 2015 11:06:14 +0100 Message-Id: <1449655574-6550-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 2.4.3 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org After adding the DT matching in commit 6f29c9afbe636fc0e35c82a11eaf45c3b85eb07a "gpio: pca935x: fix of-only probed devices" compilation fails like this: CC [M] drivers/gpio/gpio-pca953x.o gpio-pca953x.c: In function ‘pca953x_probe’: gpio-pca953x.c:693:11: error: implicit declaration of function ‘of_match_device’ [-Werror=implicit-function-declaration] match = of_match_device(pca953x_dt_ids, &client->dev); ^ gpio-pca953x.c:693:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion] match = of_match_device(pca953x_dt_ids, &client->dev); ^ cc1: some warnings being treated as errors ../scripts/Makefile.build:264: recipe for target 'drivers/gpio/gpio-pca953x.o' failed After removing the conditional inclusion guards compilation works fine again. Might be a module problem so that fix. Cc: Ben Dooks Signed-off-by: Linus Walleij --- drivers/gpio/gpio-pca953x.c | 2 -- 1 file changed, 2 deletions(-) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 14729657a112..2eaf235a39e5 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -18,9 +18,7 @@ #include #include #include -#ifdef CONFIG_OF_GPIO #include -#endif #include #define PCA953X_INPUT 0