From patchwork Fri Jun 5 09:10:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 49558 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f198.google.com (mail-lb0-f198.google.com [209.85.217.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 18F2F2154F for ; Fri, 5 Jun 2015 09:10:40 +0000 (UTC) Received: by lbbti3 with SMTP id ti3sf16343469lbb.1 for ; Fri, 05 Jun 2015 02:10:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=3G38WOxucXfVHKBe1IjCwlgbcnEB7T3rU6Z9gYvhe1g=; b=dTjx5egjtrlAB06aftpP8/N+vGpdE6psp6AaUc/NkKLLkpKOrjgOpCwRf1P9/0SmLo 1db2DkdF2jND9YPSlgXF7Te6+leIpSf7jrzyfwqG7zElflIRGN/0sD7O8sr5dTE0OdwV IO18/hED+wAIR4LEdaKevptTiA+hxiTyInzafb6skxkc8DPmYzlk+PUPWSI/hRcixJhv NauC27IdvBgSrmOsmh7VmCeCuAivTG2+P+7XWUS1RzncUsz0ncecPHdu0jbTFPfatsoz DZbr46rNxP6LZt7ETXGcwfWfep1qlPSonzmeDzHEu+5OsqDoAACWxlf8/o1X0u+iKKqu Rv+g== X-Gm-Message-State: ALoCoQkGY8l3PofWELMeu96sN4l4wTmfJ6CQhlIxixwZLlw85rGXo7UFt4rAS51cS7qtR4s7B6xW X-Received: by 10.112.171.41 with SMTP id ar9mr2358861lbc.24.1433495439066; Fri, 05 Jun 2015 02:10:39 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.27.65 with SMTP id r1ls334616lag.61.gmail; Fri, 05 Jun 2015 02:10:38 -0700 (PDT) X-Received: by 10.112.143.165 with SMTP id sf5mr2427165lbb.44.1433495438914; Fri, 05 Jun 2015 02:10:38 -0700 (PDT) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com. [209.85.217.182]) by mx.google.com with ESMTPS id de11si4292684lac.76.2015.06.05.02.10.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2015 02:10:38 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) client-ip=209.85.217.182; Received: by lbbtu8 with SMTP id tu8so26118570lbb.2 for ; Fri, 05 Jun 2015 02:10:38 -0700 (PDT) X-Received: by 10.152.206.75 with SMTP id lm11mr2322614lac.41.1433495438485; Fri, 05 Jun 2015 02:10:38 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1252603lbb; Fri, 5 Jun 2015 02:10:37 -0700 (PDT) X-Received: by 10.66.216.70 with SMTP id oo6mr4465400pac.24.1433495436816; Fri, 05 Jun 2015 02:10:36 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id vx6si10010623pab.220.2015.06.05.02.10.36; Fri, 05 Jun 2015 02:10:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932429AbbFEJKe (ORCPT + 1 other); Fri, 5 Jun 2015 05:10:34 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:35120 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932320AbbFEJK3 (ORCPT ); Fri, 5 Jun 2015 05:10:29 -0400 Received: by labko7 with SMTP id ko7so49705858lab.2 for ; Fri, 05 Jun 2015 02:10:27 -0700 (PDT) X-Received: by 10.152.245.138 with SMTP id xo10mr2404235lac.108.1433495427789; Fri, 05 Jun 2015 02:10:27 -0700 (PDT) Received: from localhost.localdomain.localdomain (c-d37f71d5.01-192-6c756e10.cust.bredbandsbolaget.se. [213.113.127.211]) by mx.google.com with ESMTPSA id ky7sm1605205lab.37.2015.06.05.02.10.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2015 02:10:26 -0700 (PDT) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Alexandre Courbot , Linus Walleij Subject: [PATCH] gpio: promote own request failure to pr_err() Date: Fri, 5 Jun 2015 11:10:21 +0200 Message-Id: <1433495421-16267-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 2.4.2 Sender: linux-gpio-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-gpio@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , These error messages are helpful to see that we fail to get hogs. Promote them to real errors so they appear in the boot crawl. Signed-off-by: Linus Walleij --- drivers/gpio/gpiolib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 6bc612b8a49f..4861b2db2edc 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -2118,13 +2118,13 @@ int gpiod_hog(struct gpio_desc *desc, const char *name, local_desc = gpiochip_request_own_desc(chip, hwnum, name); if (IS_ERR(local_desc)) { - pr_debug("requesting own GPIO %s failed\n", name); + pr_err("requesting own GPIO %s failed\n", name); return PTR_ERR(local_desc); } status = gpiod_configure_flags(desc, name, lflags, dflags); if (status < 0) { - pr_debug("setup of GPIO %s failed\n", name); + pr_err("setup of GPIO %s failed\n", name); gpiochip_free_own_desc(desc); return status; }