From patchwork Tue Nov 26 13:24:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 21779 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f200.google.com (mail-ob0-f200.google.com [209.85.214.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2BB4F202E0 for ; Tue, 26 Nov 2013 13:24:17 +0000 (UTC) Received: by mail-ob0-f200.google.com with SMTP id wm4sf18369205obc.7 for ; Tue, 26 Nov 2013 05:24:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=aeoBtaUMZWcfyzB5KW96tl6i3yy2WG30Mxxl+tuKhAc=; b=gQuRDpEW69nD71sDqPSkLyW66FBa14gHC1g6bpVDac02UH5el09EEPJqZn15saS0jn T/iweX0VnlPOp6SqjQ9kA6oxDg1AR8ukV6RUTZiDdcBWl0rYa5ROfTQL2aDRMv3fMDyX KYNlobM4HlJX1ykLMrUMlheQj6BUbMtnsXY6rKB71FSJqwhGyikhr3oUoP+P8A0tGP7r 9a3vLZL9BykVVcK2uwDHcVrbaY/pPISU/aK2rQvx/nNNPbW51gQ0J29TkpZGNID3iKep nYzpBY6RgXQTJN+vciwVh2KfKkU/7Xb5GcHK49TA8tzoOt3fnOu4VaFsQwhD4W2fBXC5 Z3LQ== X-Gm-Message-State: ALoCoQlSnQDAeA3BaCITvWpc6+Wr4rNWRpCeewgs+E8quk7x3EH5SEOFKkd+pvagBbZryoulzYeQ X-Received: by 10.42.136.136 with SMTP id u8mr8992854ict.16.1385472256739; Tue, 26 Nov 2013 05:24:16 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.35.111 with SMTP id g15ls2596226qej.21.gmail; Tue, 26 Nov 2013 05:24:16 -0800 (PST) X-Received: by 10.58.6.239 with SMTP id e15mr2431645vea.29.1385472256606; Tue, 26 Nov 2013 05:24:16 -0800 (PST) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id q6si7858428vdw.153.2013.11.26.05.24.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 26 Nov 2013 05:24:16 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id ia6so3915429vcb.32 for ; Tue, 26 Nov 2013 05:24:16 -0800 (PST) X-Received: by 10.52.245.9 with SMTP id xk9mr26200565vdc.8.1385472256518; Tue, 26 Nov 2013 05:24:16 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp212277vcz; Tue, 26 Nov 2013 05:24:16 -0800 (PST) X-Received: by 10.112.63.40 with SMTP id d8mr451494lbs.35.1385472255356; Tue, 26 Nov 2013 05:24:15 -0800 (PST) Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com [209.85.217.180]) by mx.google.com with ESMTPS id ji2si17451308lbc.126.2013.11.26.05.24.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 26 Nov 2013 05:24:14 -0800 (PST) Received-SPF: neutral (google.com: 209.85.217.180 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) client-ip=209.85.217.180; Received: by mail-lb0-f180.google.com with SMTP id w6so4333671lbh.39 for ; Tue, 26 Nov 2013 05:24:14 -0800 (PST) X-Received: by 10.112.37.134 with SMTP id y6mr5084393lbj.29.1385472253853; Tue, 26 Nov 2013 05:24:13 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id vs11sm58571041lac.3.2013.11.26.05.24.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Nov 2013 05:24:13 -0800 (PST) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Alexandre Courbot , Linus Walleij , Haojian Zhuang , Baruch Siach , Deepak Sikri Subject: [PATCH 3/3] gpio: pl061: remove confusing naming Date: Tue, 26 Nov 2013 14:24:08 +0100 Message-Id: <1385472248-26039-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.3.1 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Drop the " gpio" suffix after the pl061 irq_chip name: this is only confusing: an irqchip name should be a single, short, simple string that looks nice in /proc/interrupts. Drop the nameing of each individual IRQ to "pl061" - I think this naming function is for naming the IRQ line, not for boilerplating them all with the name of the parent controller, which is already known from the .name field of the irq_chip. Cc: Haojian Zhuang Cc: Baruch Siach Cc: Deepak Sikri Signed-off-by: Linus Walleij --- drivers/gpio/gpio-pl061.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c index c3935c58185d..621052f06e67 100644 --- a/drivers/gpio/gpio-pl061.c +++ b/drivers/gpio/gpio-pl061.c @@ -254,7 +254,7 @@ static void pl061_irq_shutdown(struct irq_data *d) } static struct irq_chip pl061_irqchip = { - .name = "pl061 gpio", + .name = "pl061", .irq_mask = pl061_irq_mask, .irq_unmask = pl061_irq_unmask, .irq_set_type = pl061_irq_type, @@ -267,8 +267,7 @@ static int pl061_irq_map(struct irq_domain *d, unsigned int irq, { struct pl061_gpio *chip = d->host_data; - irq_set_chip_and_handler_name(irq, &pl061_irqchip, handle_simple_irq, - "pl061"); + irq_set_chip_and_handler(irq, &pl061_irqchip, handle_simple_irq); irq_set_chip_data(irq, chip); irq_set_irq_type(irq, IRQ_TYPE_NONE);