From patchwork Mon Feb 27 16:45:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 657361 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 435C0C64ED6 for ; Mon, 27 Feb 2023 16:54:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230252AbjB0Qy1 (ORCPT ); Mon, 27 Feb 2023 11:54:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbjB0Qy0 (ORCPT ); Mon, 27 Feb 2023 11:54:26 -0500 Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6383016ADC for ; Mon, 27 Feb 2023 08:54:25 -0800 (PST) Received: by mail-qv1-xf36.google.com with SMTP id m4so4869949qvq.3 for ; Mon, 27 Feb 2023 08:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aL8rTLnPI0v/Bf06uo5tSLz64haWBpxVRoB2gA76eRA=; b=VKAf7oy0X5iS4amGN3vs+O8lZCfYImCXu71dohaP3yvGeZE7rx+FWjJiffiXUV7KR1 9fGoTzG1OmxvLWGvDNme/zf9aUe46VXBFNfDGcJDVK7zLbCioJOn0RQvEsmTM3FAvBaC 5+JE+fQebeux8d5lGccVEeInYnY/3YCrilCxa9XQSPDJ1Pd7NQiApFjmNWvkOH1FR/Dz s2BDQV1bOlF1YAI3svRVXt+p9CntMHufYFIsdSwt57q9ZU9dz+3MTStgzvf2zIY84Kbu si6w2CyGLXfoBzbzIV8LhlhtvbWEk6cuJoHNQO8Cq1OMXsGMKhDHlDR6NhBLKgR2nkiv J7wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aL8rTLnPI0v/Bf06uo5tSLz64haWBpxVRoB2gA76eRA=; b=nOewEqWCOJZ4QspXjonb3v97Ax/HxrjXDEWvJbDfTnYd9ReMioYMjXFFY7y+jgXp6/ CSzQIQWIutgoozTklc57KN9VQneII8gGn7DjChun/juhVR5iskJJMQrhxMIyPZjPa2OA ELclSoROwppmPK1/StGqmxrkiU25lkSE78j6/atqsk80rNseJvLkFz7RPGOdARotlmyu dBhGnR91dRrdxTvvhJ2Gov+2BpnGnWAsoHrm4cOKBL6P4Rfkw3VwEftGEf141Z8ZwJQS mWFZuHQ7IynKVZvxU06oTldXtuDS9JBig9bT93AlRajMgSHxaxe4gto9j719J1E2lQjF njCQ== X-Gm-Message-State: AO0yUKUk9ceGHkj+0A17FcnIsv9h0Hk4IrwGLlRtlPjlC9cd/RS/Qc4m GdjTePq0MRiNiIoomCKCxQrt/Q== X-Google-Smtp-Source: AK7set8zLN1AA1N7+2q0wTgldIqfC342d5e7Pg8O4fzHJgoAE8tAxTig4vC3K43uw2zmIJDFNojFQw== X-Received: by 2002:ad4:5d68:0:b0:56e:b251:a8e7 with SMTP id fn8-20020ad45d68000000b0056eb251a8e7mr401934qvb.2.1677516864521; Mon, 27 Feb 2023 08:54:24 -0800 (PST) Received: from fedora.attlocal.net (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id x15-20020a05620a098f00b0073b929d0371sm5238714qkx.4.2023.02.27.08.54.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 08:54:24 -0800 (PST) From: William Breathitt Gray To: linus.walleij@linaro.org, brgl@bgdev.pl Cc: broonie@kernel.org, andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, William Breathitt Gray Subject: [PATCH v2 2/6] gpio: 104-dio-48e: Utilize no_status regmap-irq flag Date: Mon, 27 Feb 2023 11:45:23 -0500 Message-Id: <06fd817ac5549d039e9d04b227ca7b310f36aedb.1677515341.git.william.gray@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The 104-DIO-48E lacks an IRQ status register. Rather than use the Clear Interrupt register as the status register, set the no_status flag to true and thus avoid such a hack. Reviewed-by: Andy Shevchenko Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-dio-48e.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-104-dio-48e.c b/drivers/gpio/gpio-104-dio-48e.c index a3846faf3780..fe3c93bfe4bd 100644 --- a/drivers/gpio/gpio-104-dio-48e.c +++ b/drivers/gpio/gpio-104-dio-48e.c @@ -195,13 +195,9 @@ static int dio48e_probe(struct device *dev, unsigned int id) return -ENOMEM; chip->name = name; - /* No IRQ status register so use CLEAR_INTERRUPT register instead */ - chip->status_base = DIO48E_CLEAR_INTERRUPT; chip->mask_base = DIO48E_ENABLE_INTERRUPT; chip->ack_base = DIO48E_CLEAR_INTERRUPT; - /* CLEAR_INTERRUPT doubles as status register so we need it cleared */ - chip->clear_ack = true; - chip->status_invert = true; + chip->no_status = true; chip->num_regs = 1; chip->irqs = dio48e_regmap_irqs; chip->num_irqs = ARRAY_SIZE(dio48e_regmap_irqs);