mbox series

[0/2] Fix possible deadlocks for i8255 GPIO drivers

Message ID cover.1680543810.git.william.gray@linaro.org
Headers show
Series Fix possible deadlocks for i8255 GPIO drivers | expand

Message

William Breathitt Gray April 3, 2023, 5:53 p.m. UTC 
The 104-dio-48e and 104-idi-48 drivers leverage regmap-irq to handle
IRQ. The default regmap locking utilizes spinlocks but this can result
in deadlocks for IRQ chips when running -rt kernels [0]. Enable
use_raw_spinlock for the regmap_config of these drivers to prevent such.

[0] https://lore.kernel.org/all/1466065537-82027-1-git-send-email-mika.westerberg@linux.intel.com/

William Breathitt Gray (2):
  gpio: 104-dio-48e: Enable use_raw_spinlock for dio48e_regmap_config
  gpio: 104-idi-48: Enable use_raw_spinlock for idi48_regmap_config

 drivers/gpio/gpio-104-dio-48e.c | 1 +
 drivers/gpio/gpio-104-idi-48.c  | 1 +
 2 files changed, 2 insertions(+)


base-commit: d49765b5f4320a402fbc4ed5edfd73d87640f27c

Comments

Bartosz Golaszewski April 11, 2023, 7:08 p.m. UTC | #1 
On Mon, Apr 3, 2023 at 7:53 PM William Breathitt Gray
<william.gray@linaro.org> wrote:
>
> The 104-dio-48e and 104-idi-48 drivers leverage regmap-irq to handle
> IRQ. The default regmap locking utilizes spinlocks but this can result
> in deadlocks for IRQ chips when running -rt kernels [0]. Enable
> use_raw_spinlock for the regmap_config of these drivers to prevent such.
>
> [0] https://lore.kernel.org/all/1466065537-82027-1-git-send-email-mika.westerberg@linux.intel.com/
>
> William Breathitt Gray (2):
>   gpio: 104-dio-48e: Enable use_raw_spinlock for dio48e_regmap_config
>   gpio: 104-idi-48: Enable use_raw_spinlock for idi48_regmap_config
>
>  drivers/gpio/gpio-104-dio-48e.c | 1 +
>  drivers/gpio/gpio-104-idi-48.c  | 1 +
>  2 files changed, 2 insertions(+)
>
>
> base-commit: d49765b5f4320a402fbc4ed5edfd73d87640f27c
> --
> 2.39.2
>

Both queued for fixes.

Bart