mbox series

[0/2] libgpiod: Minor fixups for 2.0 bindings

Message ID cover.1637917008.git.viresh.kumar@linaro.org
Headers show
Series libgpiod: Minor fixups for 2.0 bindings | expand

Message

Viresh Kumar Nov. 26, 2021, 9:07 a.m. UTC 
Hi Bartosz,

This patchset contain minor fixes for the libgpiod 2.0 helpers that I found
during my rust bindings work with it.

It is based on next/post-libgpiod-2.0 branch.

--
Viresh

Viresh Kumar (2):
  libgpiod: Fix ioctl number for gpiod_line_request_reconfigure_lines()
  libgpiod: Remove dummy declaration gpiod_line_config_get_event_clock()

 include/gpiod.h    | 12 ------------
 lib/line-request.c |  2 +-
 2 files changed, 1 insertion(+), 13 deletions(-)

Comments

Bartosz Golaszewski Dec. 3, 2021, 10:58 a.m. UTC | #1 
On Fri, Nov 26, 2021 at 10:07 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> Hi Bartosz,
>
> This patchset contain minor fixes for the libgpiod 2.0 helpers that I found
> during my rust bindings work with it.
>
> It is based on next/post-libgpiod-2.0 branch.
>
> --
> Viresh
>
> Viresh Kumar (2):
>   libgpiod: Fix ioctl number for gpiod_line_request_reconfigure_lines()
>   libgpiod: Remove dummy declaration gpiod_line_config_get_event_clock()
>
>  include/gpiod.h    | 12 ------------
>  lib/line-request.c |  2 +-
>  2 files changed, 1 insertion(+), 13 deletions(-)
>
> --
> 2.31.1.272.g89b43f80a514
>

Thanks a lot! Are you fine with me squashing this with the big patch
like I did with similar fixes from Ben before? The patch is
technically still under development (this kind of bugs will be
uncovered a lot once I start writing tests) and there's no reason to
merge it into master with bugs. I would keep your signed-off-by of
course.

Bart
Viresh Kumar Dec. 3, 2021, 11:14 a.m. UTC | #2 
On 03-12-21, 11:58, Bartosz Golaszewski wrote:
> Thanks a lot! Are you fine with me squashing this with the big patch
> like I did with similar fixes from Ben before? The patch is
> technically still under development (this kind of bugs will be
> uncovered a lot once I start writing tests) and there's no reason to
> merge it into master with bugs.

Sure.

> I would keep your signed-off-by of course.

Its okay to drop that as well if required, I don't care about it much :)