| Message ID | 20250503-smc-6-15-v4-0-500b9b6546fc@svenpeter.dev |
|---|---|
| Headers | show |
| Series | Apple Mac System Management Controller | expand |
On Sat, May 3, 2025 at 12:07 PM Sven Peter via B4 Relay <devnull+sven.svenpeter.dev@kernel.org> wrote: > From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk> > > Add the DT binding for the Apple Mac System Management Controller GPIOs. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > Signed-off-by: Sven Peter <sven@svenpeter.dev> LGTM Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Sat, May 3, 2025 at 12:07 PM Sven Peter via B4 Relay <devnull+sven.svenpeter.dev@kernel.org> wrote: > > From: Hector Martin <marcan@marcan.st> > > This driver implements the GPIO service on top of the SMC framework > on Apple Mac machines. In particular, these are the GPIOs present in the > PMU IC which are used to control power to certain on-board devices. > > Although the underlying hardware supports various pin config settings > (input/output, open drain, etc.), this driver does not implement that > functionality and leaves it up to the firmware to configure things > properly. We also don't yet support interrupts/events. This is > sufficient for device power control, which is the only thing we need to > support at this point. More features will be implemented when needed. > > To our knowledge, only Apple Silicon Macs implement this SMC feature. > > Signed-off-by: Hector Martin <marcan@marcan.st> > Reviewed-by: Bartosz Golaszewski <brgl@bgdev.pl> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Reviewed-by: Sven Peter <sven@svenpeter.dev> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > Signed-off-by: Sven Peter <sven@svenpeter.dev> > --- [snip] > + > + smcgp->gc.label = "macsmc-pmu-gpio"; > + smcgp->gc.owner = THIS_MODULE; > + smcgp->gc.get = macsmc_gpio_get; > + smcgp->gc.set = macsmc_gpio_set; I must have given my Reviewed-by under this driver before we started the conversion to the new GPIO driver setters. Could you please replace this with set_rv() as the old set() is now deprecated? > + smcgp->gc.get_direction = macsmc_gpio_get_direction; > + smcgp->gc.init_valid_mask = macsmc_gpio_init_valid_mask; > + smcgp->gc.can_sleep = true; > + smcgp->gc.ngpio = MAX_GPIO; > + smcgp->gc.base = -1; > + smcgp->gc.parent = &pdev->dev; > + Bart
Hi, It's been quite a while (end of 2022) since the last version of this series was sent by Russel. I'd like to pick this up again and get SMC upstream. I've taken the last version from the ML and worked in the review comments and some other changed: - Added documentation for all functions and structs - Fixed dt-bindings and re-ordered commits so that the mfd one comes last and can include the gpio subdevice - Added the reset driver and corresponding bindings - Reworked the atomic mode inside SMC since the previous implementation called mutex_lock from atomic context - Removed the backend split for now which lead to a quite intense discussion for the previous versions which hadn't been solved as far as I could tell from the old threads. It's also been 2+ years and I haven't heard of any backend implementation for T2 or even older macs. It's also unclear to me which sub-devices are actually useful there because at least GPIO and shutdown/reboot from this series will not work as-is there. I'd rather have this initial version which only supports M1+ macs upstream and then iterate there if any other backend is developed. I'll gladly help to re-introduce backend support if it's ever required. Dependencies: The code and dt-bindings themselves apply cleanly to 6.15-rc1 but the device tree changes require the already merged SPMI controller and SPMI NVMEM series which will be part of 6.16. The series is also using the printf format specifiers which will land in 6.16 via the drm-misc tree. A tree with all dependencies for testing is available at https://github.com/AsahiLinux/linux/commits/sven/smc-v4/. Merging: The dt-binding patches all depend on each other such that they all should probably go together with the mfd device itself. The following commits also depend on mfd due to the new header file and will either have to go through the mfd tree as well or we'll need an immutable branch there. I'll take the device tree updates through our tree which also has the previous device tree updates these depend on. v3: https://lore.kernel.org/asahi/Y2qEpgIdpRTzTQbN@shell.armlinux.org.uk/ v2: https://lore.kernel.org/asahi/YxdInl2qzQWM+3bs@shell.armlinux.org.uk/ v1: https://lore.kernel.org/asahi/YxC5eZjGgd8xguDr@shell.armlinux.org.uk/ Best, Sven --- Hector Martin (5): gpio: Add new gpio-macsmc driver for Apple Macs power: reset: macsmc-reboot: Add driver for rebooting via Apple SMC arm64: dts: apple: t8103: Add SMC node arm64: dts: apple: t8112: Add SMC node arm64: dts: apple: t600x: Add SMC node Russell King (Oracle) (2): dt-bindings: gpio: Add Apple Mac SMC GPIO block dt-bindings: mfd: Add Apple Mac System Management Controller Sven Peter (2): dt-bindings: power: reboot: Add Apple Mac SMC Reboot Controller mfd: Add Apple Silicon System Management Controller .../devicetree/bindings/gpio/apple,smc-gpio.yaml | 37 ++ .../devicetree/bindings/mfd/apple,smc.yaml | 71 +++ .../bindings/power/reset/apple,smc-reboot.yaml | 52 ++ MAINTAINERS | 7 + arch/arm64/boot/dts/apple/t600x-die0.dtsi | 35 ++ arch/arm64/boot/dts/apple/t8103.dtsi | 35 ++ arch/arm64/boot/dts/apple/t8112.dtsi | 35 ++ drivers/gpio/Kconfig | 10 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-macsmc.c | 246 ++++++++ drivers/mfd/Kconfig | 15 + drivers/mfd/Makefile | 1 + drivers/mfd/macsmc.c | 657 +++++++++++++++++++++ drivers/power/reset/Kconfig | 11 + drivers/power/reset/Makefile | 1 + drivers/power/reset/macsmc-reboot.c | 362 ++++++++++++ include/linux/mfd/macsmc.h | 337 +++++++++++ 17 files changed, 1913 insertions(+) --- base-commit: 8b7e6734e2231a549a23943678ee3452bd19a1fe change-id: 20250304-smc-6-15-f0ed619e31d4 Best regards,