mbox series

[v1,0/2] gpiolib:legacy: Kill GPIOF_DIR_* and GPIOF_INIT_*

Message ID 20240828142554.2424189-1-andriy.shevchenko@linux.intel.com
Headers show
Series gpiolib:legacy: Kill GPIOF_DIR_* and GPIOF_INIT_* | expand

Message

Andy Shevchenko Aug. 28, 2024, 2:23 p.m. UTC 
Shrink the legacy API and definition surface by killing the (internal)
definitions. This, in particular, will fix a couple of drivers that took
it wrong.

This is assumed to go via BPIOLIB tree as this is quite small series and
most of the changes related to it.

Andy Shevchenko (2):
  gpiolib: legacy: Kill GPIOF_INIT_* definitions
  gpiolib: legacy: Kill GPIOF_DIR_* definitions

 arch/arm/mach-ep93xx/vision_ep9307.c      |  6 ++----
 arch/mips/bcm63xx/boards/board_bcm963xx.c |  2 +-
 drivers/gpio/gpiolib-legacy.c             |  5 ++---
 include/linux/gpio.h                      | 12 +++---------
 4 files changed, 8 insertions(+), 17 deletions(-)

Comments

Andy Shevchenko Aug. 28, 2024, 3:11 p.m. UTC | #1 
On Wed, Aug 28, 2024 at 05:23:56PM +0300, Andy Shevchenko wrote:
> Shrink the legacy API and definition surface by killing the (internal)
> definitions. This, in particular, will fix a couple of drivers that took
> it wrong.
> 
> This is assumed to go via BPIOLIB tree as this is quite small series and
> most of the changes related to it.

Hmm... LKP complained that it can't apply them on top of Linux Next, however
I don't see any issues as my branch based on next-20240828.

Tell me if I need to resend.
Linus Walleij Aug. 30, 2024, 10:35 p.m. UTC | #2 
On Wed, Aug 28, 2024 at 4:26 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Besides the fact that (old) drivers use wrong definitions, e.g.,
> GPIOF_DIR_IN instead of GPIOF_IN, shrink the legacy definitions
> by killing those GPIOF_DIR_* completely.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Bartosz Golaszewski Sept. 2, 2024, 9:47 a.m. UTC | #3 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 28 Aug 2024 17:23:56 +0300, Andy Shevchenko wrote:
> Shrink the legacy API and definition surface by killing the (internal)
> definitions. This, in particular, will fix a couple of drivers that took
> it wrong.
> 
> This is assumed to go via BPIOLIB tree as this is quite small series and
> most of the changes related to it.
> 
> [...]

Applied, thanks!

[1/2] gpiolib: legacy: Kill GPIOF_INIT_* definitions
      commit: 4b2b0a2ce8153d65d0829e45e73bf6acdc291344
[2/2] gpiolib: legacy: Kill GPIOF_DIR_* definitions
      commit: 8c045ca534d03bab1ce4b4de49d29a36276a1e35

Best regards,