| Message ID | 20240710125719.33655-1-brgl@bgdev.pl |
|---|---|
| Headers | show |
| Series | bindings: python: fix line request by name with multiple entries | expand |
On Wed, Jul 10, 2024 at 02:57:17PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > We haven't heard from Chuang in two weeks but I want to finalize this > series so I applied the hints from Kent. > > Changes in v3: > - tweak the commit messages > - change the test class name > - improve the test case by testing one more line name > > Chuang Zhu (2): > bindings: python: fix line request by name with multiple entries > bindings: python: tests: add a new test case > I prefer adding the test case first, to demonstrate the problem before fixing it, but it isn't a deal breaker. Other than that, looks good to me. Reviewed-by: Kent Gibson <warthog618@gmail.com> for the series.
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> We haven't heard from Chuang in two weeks but I want to finalize this series so I applied the hints from Kent. Changes in v3: - tweak the commit messages - change the test class name - improve the test case by testing one more line name Chuang Zhu (2): bindings: python: fix line request by name with multiple entries bindings: python: tests: add a new test case bindings/python/gpiod/chip.py | 7 +++-- bindings/python/tests/tests_line_request.py | 34 +++++++++++++++++++++ 2 files changed, 38 insertions(+), 3 deletions(-)